Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Access not Async #37

Open
IAPark opened this issue Feb 10, 2016 · 1 comment
Open

DB Access not Async #37

IAPark opened this issue Feb 10, 2016 · 1 comment

Comments

@IAPark
Copy link

IAPark commented Feb 10, 2016

This is actually an issue I have fixed, but it's part of a much larger overhaul, now stalled until I have more time, meant to fix architectural issues and add unit testing. Regardless it's something that probably should be resolved before the next map. To be honest I thought it had been fixed so I was a bit surprised to find the code still blocking.

My code hasn't been tested and as I mentioned there are a number of other massive refactors, but this should give an idea of what's needed in general.

https://github.com/IAPark/Bastion/blob/Bastion-Storage-Refactor/Bastion/src/isaac/bastion/BastionBlock.java#L143-L160

Here's how it's currently handled

https://github.com/Civcraft/Bastion/blob/master/Bastion/src/isaac/bastion/BastionBlock.java#L169-L187

@ProgrammerDan
Copy link

Current implementation is middle road -- requests are shared among a connection pool, so the DB resource is non-blocking against simultaneous requests. However, there is no concerted framework for async. I'll leave this open for now as it's still a good goal, but I don't know that it will receive attention.

Maxopoly pushed a commit to Maxopoly/Bastion that referenced this issue Dec 27, 2017
…xplosion handler for Civcraft#32 and putting bastions back on the pending list if Creation is cancelled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants