You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is actually an issue I have fixed, but it's part of a much larger overhaul, now stalled until I have more time, meant to fix architectural issues and add unit testing. Regardless it's something that probably should be resolved before the next map. To be honest I thought it had been fixed so I was a bit surprised to find the code still blocking.
My code hasn't been tested and as I mentioned there are a number of other massive refactors, but this should give an idea of what's needed in general.
Current implementation is middle road -- requests are shared among a connection pool, so the DB resource is non-blocking against simultaneous requests. However, there is no concerted framework for async. I'll leave this open for now as it's still a good goal, but I don't know that it will receive attention.
Maxopoly
pushed a commit
to Maxopoly/Bastion
that referenced
this issue
Dec 27, 2017
This is actually an issue I have fixed, but it's part of a much larger overhaul, now stalled until I have more time, meant to fix architectural issues and add unit testing. Regardless it's something that probably should be resolved before the next map. To be honest I thought it had been fixed so I was a bit surprised to find the code still blocking.
My code hasn't been tested and as I mentioned there are a number of other massive refactors, but this should give an idea of what's needed in general.
https://github.com/IAPark/Bastion/blob/Bastion-Storage-Refactor/Bastion/src/isaac/bastion/BastionBlock.java#L143-L160
Here's how it's currently handled
https://github.com/Civcraft/Bastion/blob/master/Bastion/src/isaac/bastion/BastionBlock.java#L169-L187
The text was updated successfully, but these errors were encountered: