Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check conf before restart #30

Open
auguster opened this issue Mar 1, 2016 · 3 comments
Open

Check conf before restart #30

auguster opened this issue Mar 1, 2016 · 3 comments

Comments

@auguster
Copy link

auguster commented Mar 1, 2016

I just had a nasty crash of haproxy-consul because the data coming from consul led to a bad haproxy.cfg file. This caused haproxy to crash on restart, stopping the container.

I would be nice if haproxy-consul could check the config file (using haproxy -f /haproxy/haproxy.cfg -c) and if it's clean, only then restart haproxy. I would make the overall more robust and more trustworthy ;-)

@lalarsson
Copy link
Contributor

Your wish has been brought into existence in PR #37 :)

@auguster
Copy link
Author

auguster commented Jun 8, 2016

@lalarsson thanks, looking forward seeing this merged ;-)

@lalarsson
Copy link
Contributor

@auguster: @stevendborrelli have just merged it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants