We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly a brain dump of things I found weird
welcome_code not welcome_reply (all other reply packets use the x_reply naming
welcome_code
welcome_reply
x_reply
spell vs skill (should stick with skill I think)
spell
skill
item vs buy_item sell_item drop_item etc (think we should keep it simple and just use item)
item
buy_item
sell_item
drop_item
base and secondary vs base_stats and secondary_status
base
secondary
base_stats
secondary_status
NpcType::Trainer should be SkillMaster ?
NpcType::Trainer
SkillMaster
victim vs target (victim doesn't really make sense for heal spells
victim
target
level_up should be level_up_stats in npc packets
level_up
level_up_stats
ChestReply server packet could use Item rather than item_id and remaining_item_amount
Item
item_id
remaining_item_amount
Will add more later probably. Ignore until I let you know it's complete :P
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Mostly a brain dump of things I found weird
welcome_code
notwelcome_reply
(all other reply packets use thex_reply
namingspell
vsskill
(should stick with skill I think)item
vsbuy_item
sell_item
drop_item
etc (think we should keep it simple and just useitem
)base
andsecondary
vsbase_stats
andsecondary_status
NpcType::Trainer
should beSkillMaster
?victim
vstarget
(victim doesn't really make sense for heal spellslevel_up
should belevel_up_stats
in npc packetsChestReply server packet could use
Item
rather thanitem_id
andremaining_item_amount
Will add more later probably. Ignore until I let you know it's complete :P
The text was updated successfully, but these errors were encountered: