forked from brave/brave-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
/
PULL_REQUEST_TEMPLATE
33 lines (23 loc) · 1.21 KB
/
PULL_REQUEST_TEMPLATE
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
<!-- *Thank you for submitting a pull request, your contributions are greatly appreciated!* -->
## Summary of Changes
<!-- Enter a ticket number for this PR, create a new one if it is not there yet. -->
This pull request fixes #<number>
## Submitter Checklist:
- [ ] *Unit Tests* are updated to cover new or changed functionality
- [ ] User-facing strings use `NSLocalizableString()`
- [ ] New or updated UI has been tested across:
- [ ] Light & dark mode
- [ ] Different size classes (iPhone, landscape, iPad)
- [ ] Different dynamic type sizes
## Test Plan:
<!-- Any useful notes explaining how best to test and verify. -->
## Screenshots:
<!-- If your patch includes user interface changes that you would like to suggest or that you would like UX to look at, please include them here. -->
## Reviewer Checklist:
- [ ] Issues include necessary QA labels:
- `QA/(Yes|No)`
- `bug` / `enhancement`
- [ ] Necessary [security reviews](https://github.com/brave/security/issues/new/choose) have taken place.
- [ ] Adequate unit test coverage exists to prevent regressions.
- [ ] Adequate test plan exists for QA to validate (if applicable).
- [ ] Issue and pull request is assigned to a milestone (should happen at merge time).