Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic function assignment cause stack error #322

Open
nedisy opened this issue Jan 18, 2022 · 4 comments
Open

Cyclic function assignment cause stack error #322

nedisy opened this issue Jan 18, 2022 · 4 comments

Comments

@nedisy
Copy link
Contributor

nedisy commented Jan 18, 2022

Hello, I think I found a bug,

add g to the text cursor in this picture and the app will crash
image

the log:
www.math3d.org-1642475359497.log

@nedisy
Copy link
Contributor Author

nedisy commented Jan 18, 2022

After I read the code related, I think the problem is the getDescendants function called before cyclic dependencies get erased in childMap, so there will be cyclic calls in getDescendants, thus the stack error. This specifically happens if the value of constant "onlyTheseAndChildren" is not null, the only time getDescendants is called.

Math3d_ Online 3d Graphing Calculator Error Log.pdf
Math3d_ Online 3d Graphing Calculator Error Log_page-0001

@o-b-o
Copy link

o-b-o commented Jan 24, 2022

What were you trying to do? Some sort of recursive definition?

@nedisy
Copy link
Contributor Author

nedisy commented Jan 25, 2022

Trying to test if it will throw an error

@o-b-o
Copy link

o-b-o commented Jan 26, 2022

Trying to do this in python will throw an error too. You need to define one function first, you can then define another as the original function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants