New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mediation offers more object-oriented #79

Open

5 tasks

ChrisBAshton opened this issue May 1, 2015 · 0 comments

Labels

Owner

ChrisBAshton commented May 1, 2015

This is probably the biggest oversight in my design and needs refactoring. Quite a hefty unit of work though:

Create a MediationEntityOffer object
Move the necessary methods from DBMediation.php to DBGet
Remove DBMediation.php
Correct the necessary methods in DBCreate/DBUpdate
Remove MediationState.php. Handle its specific logic elsewhere; perhaps make it a subclass of the DisputeState like all the other states.

ChrisBAshton added the technical debt label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment