refresh() does not take allowHTML into account #1220

yubbink · 2024-10-11T11:43:04Z

Describe the bug
The option allowHTML when creating a choice element allows label to have html input instead of just text. When you call .refresh() on the created choice element after that, it does not render the text inside label as html, but as normal text. Causing html tags to be displayed.

To Reproduce

<!doctype html>
<html>
<head>
    <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/choices.js/public/assets/styles/choices.min.css"/>
    <script src="https://cdn.jsdelivr.net/npm/[email protected]/public/assets/scripts/choices.min.js"></script>
</head>
<body>
<div>
    <select id="select"></select>
    <button onclick="window.choiceElement.refresh()">Click to refresh</button>
</div>
<script>
    window.choiceElement = new Choices(document.querySelector('#select'), {
        allowHTML: true,
    });

    window.choiceElement.setChoices([
        {
            value: '1',
            label: '<div>Text inside html tag</div>',
            selected: true
        }
    ], 'value', 'label', true)
</script>
</body>

click the button to call the refresh function and you'll see the selected element changing and showing the html tags

Expected behavior
You'd expect the html to render instead of plain text

Choices version and bundle
Found this bug in 10.2.0 under different circumstances, but as the example shows it is a problem in 11.0.2. Simple example with 10.2.0 version works, so I'm trying to find the underlaying cause for the same issue I'm facing there.

The text was updated successfully, but these errors were encountered:

yubbink added the bug label Oct 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refresh() does not take allowHTML into account #1220

refresh() does not take allowHTML into account #1220

yubbink commented Oct 11, 2024 •

edited

Loading

refresh() does not take allowHTML into account #1220

refresh() does not take allowHTML into account #1220

Comments

yubbink commented Oct 11, 2024 • edited Loading

yubbink commented Oct 11, 2024 •

edited

Loading