Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test, that writes partial arrays, to the UnifiedBackendTest #204

Open
zenker opened this issue Mar 26, 2021 · 1 comment
Open

Add test, that writes partial arrays, to the UnifiedBackendTest #204

zenker opened this issue Mar 26, 2021 · 1 comment

Comments

@zenker
Copy link
Collaborator

zenker commented Mar 26, 2021

Writing partial arrays, where the Accessor size is different from the target array length, is not tested by the UnifiedBackendTest.
If there is some offset set and the array length is different from the Accessor size, one has to read the whole array once and only modify the elements accessed by the Accessor. This is not the case if partial writing is possible.
It is not possible e.g. for the DOOCS, EPICS, OPC UA backend.
The correct implementation should be tested to make sure backends where partial writing is not possible do everything correct (read_modify_write).

@mhier
Copy link
Member

mhier commented Mar 29, 2021

Test for partial reads is also missing. This is not as easy to go wrong but still should be tested. In principle, the UnfiedBackendTest should test both partial reads and writes for any array register.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants