Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenId modifier stacking (Unit-tied unique stacking) #15

Open
Chillu1 opened this issue Sep 30, 2023 · 0 comments
Open

GenId modifier stacking (Unit-tied unique stacking) #15

Chillu1 opened this issue Sep 30, 2023 · 0 comments
Labels
enhancement New feature or request modifier logic request New modifier logic for more lacking functionality

Comments

@Chillu1
Copy link
Owner

Chillu1 commented Sep 30, 2023

Description
Currently, instance stackable modifiers are always stacked when added, no matter what.
It would be nice to have stackable modifiers based on who is the source of the modifier. Meaning that a single Unit can only apply one instance of the modifier, but if another Unit applies the same modifier type, it will be another instance. With its own independent refresh, stack, etc.

Example: Two Units have a modifier named "DamageOverTime", Unit 1 applies it, then Unit 2 applies it. The target Unit now has two unique instances of that modifier, ticking together, if Unit 1 applies it again, the modifier will be refreshed, stacked, etc. But the 2nd instance applied by Unit 2

Implementation
Only ModifierController will need to have extra logic, by checking if the modifier exist and if they're instance stackable, and instance genId stackable or not.

Issues
For this to work, a GenId needs to be fed into ModifierController.Add, and currently we don't have access to the GenId a lot of the time, so it would either need a new id system based on casters, or some refactoring.

@Chillu1 Chillu1 added the enhancement New feature or request label Sep 30, 2023
@Chillu1 Chillu1 added the modifier logic request New modifier logic for more lacking functionality label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modifier logic request New modifier logic for more lacking functionality
Projects
None yet
Development

No branches or pull requests

1 participant