Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect issue on successful validation - Login Formik #120

Open
priyankavrao97 opened this issue Apr 11, 2023 · 4 comments
Open

Redirect issue on successful validation - Login Formik #120

priyankavrao97 opened this issue Apr 11, 2023 · 4 comments
Assignees
Labels
High Priority UI Concerns UI presentation

Comments

@priyankavrao97
Copy link
Contributor

priyankavrao97 commented Apr 11, 2023

conflict with the newly added login api connection and Formik update in login form

priyankavrao97 added a commit that referenced this issue Apr 11, 2023
Improving login form with formik for easy form validation.
@hardikpatil hardikpatil reopened this Apr 12, 2023
@hardikpatil
Copy link
Contributor

hardikpatil commented Apr 12, 2023

Validation testing looks good but however, issue reopened in order to address route/redirect issue after successful validation.

@hardikpatil hardikpatil changed the title Adding formik for login page Redirect issue on successful validation - Login Formik Apr 12, 2023
@hardikpatil hardikpatil added the UI Concerns UI presentation label Apr 14, 2023
@MMurtey MMurtey self-assigned this Apr 27, 2023
@MMurtey
Copy link
Contributor

MMurtey commented Apr 27, 2023

I can look into this. @priyankavrao97, I'll connect with you for a little more background.

@MMurtey
Copy link
Contributor

MMurtey commented May 8, 2023

I've added a branch essentially I believe handles this issue (although it needs refinement on the UI side): register_backend_connect. But, in order to get the registration form working, I had to make changes to the app in order to get the frontend talking to the backend, so the branch isn't really "single feature," but this was necessary. (Thanks @prestonmasseyblake for the assist on this.)

@MMurtey
Copy link
Contributor

MMurtey commented May 9, 2023

My mistake. The changes mentioned in my previous comment affect registration, not login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority UI Concerns UI presentation
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants