Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to reflect reinstatement on CRAN #228

Closed
geneorama opened this issue Aug 31, 2023 · 4 comments
Closed

Update README.md to reflect reinstatement on CRAN #228

geneorama opened this issue Aug 31, 2023 · 4 comments

Comments

@geneorama
Copy link
Member

No description provided.

@ajlyons
Copy link

ajlyons commented Aug 31, 2023

Thank you for getting RSocrata back on CRAN!

Another little update you might want to make to README.md is that install_github is now part of the remotes package. It was split off from devtools a few years back (although devtools republishes it so legacy code still works).

@geneorama
Copy link
Member Author

Thanks, that's good to know. Is there any advantage to changing?

I'm inclined to keep devtools since that package is already used for checking and documenting, and it's not warning to switch. Thoughts?

I was currently trying to figure out why the Travis and CRAN badges are not working as expected. Perhaps it's because the README.md was excluded from the package (for the CRAN badge).

@geneorama
Copy link
Member Author

For now it's the same in the interests of getting the README updated.

@ajlyons
Copy link

ajlyons commented Sep 2, 2023

I'm not sure about all the pros and cons of recommending users install the package with remotes::install_github() vs devtools::install_github(). devtools is of course a much bigger package and may be more of lift for users to install and have more impact on memory. The authors of devtools split off all the install_xxxx functions into remotes as a lightweight package that only installs packages from GitHub, GitLab, Bitbucket, Bioconductor. But whichever one you show in the README.md should have no bearing on the badges, checking and other continuous integration tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants