Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing CRAN checks, due by 9/10 #196

Closed
nicklucius opened this issue Sep 7, 2021 · 3 comments
Closed

Failing CRAN checks, due by 9/10 #196

nicklucius opened this issue Sep 7, 2021 · 3 comments

Comments

@nicklucius
Copy link
Contributor

See https://cran.r-project.org/web/checks/check_results_RSocrata.html

@nicklucius
Copy link
Contributor Author

CRAN checks are failing because a dataset that we are using for testing no longer exists. The dataset was an example of one that triggered a failure documented in #118. We no longer have an examples of a dataset that would trigger this error. This calls for removing the test since we can't run it on an actual real-life example dataset.

@geneorama could you take a look at this and if you agree, make the change so we can stay on CRAN? We have 2 days.

@geneorama
Copy link
Member

I agree, that is the issue. I don't know how to fix the test because I don't know how to find another dataset with missing SODA2 headers. I modified the test to take out the checks and committed it to a new branch, issue196.

@geneorama
Copy link
Member

@nicklucius I have not updated the DESCRIPTION and put in a pull request. According to the documentation we should submit the pull request to dev, but that's behind master. Do you want me to make a pull request to master and make it version 1.7.10-7 (currently master is 1.7.10-6)?

geneorama added a commit that referenced this issue Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants