Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing CRAN checks - due 10/16 #183

Closed
nicklucius opened this issue Oct 3, 2019 · 4 comments
Closed

Failing CRAN checks - due 10/16 #183

nicklucius opened this issue Oct 3, 2019 · 4 comments

Comments

@nicklucius
Copy link
Contributor

https://cran.r-project.org/web/checks/check_results_RSocrata.html

@geneorama
Copy link
Member

geneorama commented Oct 18, 2019

RSocrata was pulled off CRAN, this time they didn't give much warning, just one email on 10/2.

The only failing test I see is documented as relating to issue #118, line 131 of the test script. The data set is returning 146 columns instead of 150.

Edit: I linked to the test, the actual failing part is this part expect_equal(150, ncol(dfCsv), label="columns", info="https://github.com/Chicago/RSocrata/issues/118")

@geneorama
Copy link
Member

Also, the link to the CRAN checks is no longer available, so I can't confirm that the errors I'm seeing are the same that they were seeing
https://cran.r-project.org/web/checks/check_results_RSocrata.html

@nicklucius
Copy link
Contributor Author

Changing the expected number of columns to 146 fixes the issue and all tests pass. Socrata changed the number of columns in this dataset. Since the test itself is unrelated to the number of columns, I think the fact that the test now passes means that the breakage is resolved and we should resubmit to CRAN.

I'll start another issue to investigate the column number change as well as other inconsistencies reported by @geneorama in #118.

nicklucius added a commit that referenced this issue Oct 23, 2019
@nicklucius
Copy link
Contributor Author

We are now passing CRAN checks and have submitted the package to be back on CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants