Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead link and fix Contributing.md link #178

Closed
nicklucius opened this issue Jun 24, 2019 · 3 comments
Closed

Remove dead link and fix Contributing.md link #178

nicklucius opened this issue Jun 24, 2019 · 3 comments

Comments

@nicklucius
Copy link
Contributor

Waffle.io shut down on 5/16/19, which of course broke our link in README.md. CRAN requires this to be removed.

Separately, the link to CONTRIBUTING.md in README.md is a relative link that uses GitHub markdown shorthand. CRAN requires this to be specified by full URL.

@geneorama
Copy link
Member

If I'm reading this right there a new error related to issue #19 from Appveyor. We recently had other issues with this example when the publishers changed the data set and appeared to clean up old records.

@geneorama
Copy link
Member

  OK: 139 SKIPPED: 4 WARNINGS: 4 FAILED: 1
684  1. Error: read Socrata JSON with missing fields (issue 19 - binding pages together) (@test-all.R#260) 
685  
686  Error: testthat unit tests failed
687  Execution halted

@geneorama
Copy link
Member

Not sure what that was on Appveyor, I'm not seeing the same thing when I run the tests locally.

geneorama added a commit that referenced this issue Jun 24, 2019
Fix URLs in README.md (fixes #178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants