Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more keywords #22

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add more keywords #22

merged 1 commit into from
Nov 2, 2022

Conversation

zane
Copy link
Contributor

@zane zane commented Oct 27, 2022

Overview

  • Highlights CROSS, INNER, JOIN, ON as keywords in table expressions.
  • Highlights DISTINCT as a keyword in scalar expressions.

Motivation

@zane zane added feat New feature or request test labels Oct 27, 2022
@zane zane requested a review from Schaechtle October 27, 2022 19:21
@zane zane self-assigned this Oct 27, 2022
Copy link
Contributor

@Schaechtle Schaechtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we should add INNER (see grammar here).

@Schaechtle
Copy link
Contributor

... and ON.

@zane zane force-pushed the zane/more-keywords branch 2 times, most recently from 9066702 to ad9b913 Compare November 2, 2022 19:34
@zane zane force-pushed the zane/more-keywords branch from ad9b913 to 228abb7 Compare November 2, 2022 19:39
@zane zane merged commit f90e993 into main Nov 2, 2022
@zane zane deleted the zane/more-keywords branch November 2, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add syntax highlighting for the DISTINCT keyword Highlight JOIN keywords
2 participants