Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues in the documentation #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions docs/modules/ROOT/partials/base/scalar-expressions.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ Basic arithmetic like multiplication, subtraction, addition, and division can be
====
[source,iql]
----
SELECT PROBABILITY OF VAR Apogee_km > Apogee_km UNDER military_model
SELECT
PROBABILITY OF VAR Apogee_km > Apogee_km
UNDER military_model
FROM satellites
----
====

Expand All @@ -56,8 +59,10 @@ SELECT PROBABILITY OF VAR Apogee_km > Apogee_km UNDER military_model
====
[source,iql]
----
SELECT PROBABILITY DENSITY OF VAR Apogee_km < 1000
UNDER model CONDITIONED BY VAR Users = "Military"
SELECT
PROBABILITY DENSITY OF VAR Apogee_km < 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're fixing this: PROBABILITY DENSITY OF VAR Apogee_km < 1000 will crash because PROBABILITY DENSITY takes a density event (i.e. involving equality). VAR Apogee_km < 1000 above is a distribution event.

UNDER model CONDITIONED BY VAR Users = "Military"
FROM satellites
----
====

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ The `+WITH+` keyword allows you to bind names to values for the lifetime of a qu
----
WITH (satellites_model GIVEN Users = "Military") AS military_model:
SELECT PROBABILITY OF Apogee_km UNDER military_model
FROM satellites
----
====
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ The `+WITH+` keyword allows you to bind names to values for the lifetime of a qu
----
WITH (satellites_model CONDITIONED BY VAR Users = "Military") AS military_model:
SELECT PROBABILITY OF VAR Apogee_km > Apogee_km UNDER military_model
FROM satellites
----
====