Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam Wave UI problems - default isn't really 24h? #1010

Open
tripleee opened this issue Aug 7, 2024 · 1 comment
Open

Spam Wave UI problems - default isn't really 24h? #1010

tripleee opened this issue Aug 7, 2024 · 1 comment

Comments

@tripleee
Copy link
Member

tripleee commented Aug 7, 2024

The labeling says that the default expiry for a spam wave is 24 hours, but leaving it empty actually produces a Rails traceback.

Also, when I entered "24h", it seems to have produced a spam wave which would expire in 12 hours. What exactly is the expected input format? Could the box be prepopulated with "24 hours" in whichever format the back end expects the value?

I also struggled a bit with the site filter; it defaults to no sites which is less than helpful, and toggling between all and none seemed slightly erratic (though perhaps that was only because I navigated back from the traceback with the back button).

@makyen
Copy link
Contributor

makyen commented Aug 7, 2024

I'm a bit confused by this. When you first open the new spam wave creation page, that field is pre-filled with the full UTC date that is 24 hours from the current time and there's an "in 48 hours" button right there that fills that field with the correctly formatted UTC date that is 48 hours from when you click the button. Those, at least to me, give a clear indication of the expected format for that input. It's unclear to me why one would think that "24h" or " 24 hours" would be valid inputs for that field.

Clearly, it could communicate things better, but it's unclear to me how to make it clearer when an example of the correct format is provided.

Ahhh... I see... The probable reason you don't see that field be populated when the page loads is probably that you are using Chrome and Chrome/Google has chosen in the most recent version of Chrome (as of 2024-07-30) to disable the JavaScript that fills that field. See the console errors which Chrome produces, which links to https://chromestatus.com/feature/5083947249172480 for explanation.

I wouldn't be surprised if this choice by Chrome to disable backward compatibility is what's causing multiple problems for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants