Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integrated flux values automatically when toggling "Integrate Model" on and off #106

Open
jbudynk opened this issue Apr 9, 2015 · 2 comments

Comments

@jbudynk
Copy link
Member

jbudynk commented Apr 9, 2015

If "Integrate Model" is OFF, then you add a passband, toggle the "Integrate Model" button back ON, and add a new passband, the flux value from the new passband is calculated by integrating the model, while the old passband's flux value is still from the raw SED. The user has to click "Calculate" to update the old passband flux value.

Instead, when a user toggles "Integrate Model," the flux values should automatically update.

Test:

SED: 3c066a
model: brokenpowerlaw (default), chi2datavar and neldermead

Integrate model (OFF). Add a user-defined passband from 5000 to 1e5 Angstroms. Add a photometry filter (SLOAN sdss.g).

Turn integrate model ON. Add another user-defined passband from 0.01 to 0.1 keV. The latest passband is calculated from integrating under the model, while the other two passbands still show the results from integrating under the raw SED. Clicking "Calculate" updates the flux values as expected.

@olaurino
Copy link
Member

This is related to (and spawned from) issue #80 and PR #105

@olaurino
Copy link
Member

This is most likely trivial to fix, but since we had to deal with more pressing issues, I am putting this back into the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants