Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(annotations)!: improve annotation-based plugin generation #337

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

refactor(annotations)!: improve annotation-based plugin generation #337

wants to merge 3 commits into from

Conversation

joshuasing
Copy link
Member

@joshuasing joshuasing commented Nov 26, 2023 •
edited
Loading

Summary
Rewrites the majority of the chameleon-annotations module.
Fixes #171

Changes

  • Use template-based code generation to improve maintainability and readability. Previously JavaPoet was used, which resulted in code generation being hard to maintain and understand.
  • Add a @PluginGeneratorOptions annotation, which allows users to further customise how generation works, such as how classes and packages are named.
  • Overall code cleanup.

Checklist

This pull request contains breaking changes.

THIS PULL REQUEST IS A WORK IN PROGRESS.

@joshuasing joshuasing added type: enhancement This is a feature request or a pull request that adds a feature status: in progress This is being actively worked on status: breaking This involves breaking an existing API area: annotations This involves updating, adding or removing code relating to annotation processing type: refactor This refactors existing code size: XL labels Nov 26, 2023
@joshuasing joshuasing added this to the v0.20.0 milestone Nov 26, 2023
@joshuasing joshuasing self-assigned this Nov 26, 2023
@joshuasing joshuasing marked this pull request as draft November 26, 2023 16:53
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.20%. Comparing base (596b1a6) to head (3475ae2).
Report is 28 commits behind head on main.

❗ Current head 3475ae2 differs from pull request most recent head 1f8c72d. Consider uploading reports for the commit 1f8c72d to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #337      +/-   ##
============================================
- Coverage     69.76%   69.20%   -0.56%     
  Complexity      652      652              
============================================
  Files            90       89       -1     
  Lines          2163     2166       +3     
  Branches        147      148       +1     
============================================
- Hits           1509     1499      -10     
- Misses          618      633      +15     
+ Partials         36       34       -2
Files Coverage Δ
.../hypera/chameleon/util/internal/ChameleonUtil.java 12.50% <0.00%> (-20.84%) ⬇️

... and 6 files with indirect coverage changes

@joshuasing joshuasing modified the milestones: v0.20.0, v0.21.0 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LooFifteen LooFifteen Awaiting requested review from LooFifteen LooFifteen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@joshuasing joshuasing

Labels
area: annotations This involves updating, adding or removing code relating to annotation processing size: XL status: breaking This involves breaking an existing API status: in progress This is being actively worked on type: enhancement This is a feature request or a pull request that adds a feature type: refactor This refactors existing code
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

Improved platform plugin class generation
1 participant
@joshuasing