From 85cbd30bb717742db20bc2b7a9d03ec9819f70e8 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 10:29:43 +0100 Subject: [PATCH 01/12] Fix ci coverage --- .codecov.yml | 6 ++++++ .github/workflows/test.yml | 2 +- package.json | 2 +- packages/api/package.json | 2 +- packages/beacon-node/package.json | 2 +- packages/config/package.json | 1 + packages/db/package.json | 2 +- packages/flare/package.json | 1 + packages/fork-choice/package.json | 2 +- packages/light-client/package.json | 2 +- packages/logger/package.json | 1 + packages/params/package.json | 1 + packages/prover/package.json | 2 +- packages/reqresp/package.json | 2 +- packages/spec-test-util/package.json | 1 + packages/state-transition/package.json | 1 + packages/types/package.json | 1 + packages/utils/package.json | 1 + packages/validator/package.json | 2 +- 19 files changed, 24 insertions(+), 10 deletions(-) diff --git a/.codecov.yml b/.codecov.yml index 45b353124178..0b28a665cceb 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -34,3 +34,9 @@ ignore: - "supporting-docs" - "docker" - ".github" + +flags: + unit: + paths: + - packages/**/test/unit + carryforward: true diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d865045c4f3a..05aae4b6af28 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -194,7 +194,7 @@ jobs: # if: ${{ failure() && steps.unit_tests.conclusion == 'failure' }} - name: Upload coverage data - run: yarn coverage + run: yarn coverage -F unit e2e-tests: name: E2E Tests diff --git a/package.json b/package.json index 5d7a90f27e6f..c7d1a475db1c 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "check-readme": "lerna run check-readme", "check-types": "lerna run check-types", "check-spelling": "pyspelling -c .pyspelling.yml -v", - "coverage": "lerna run coverage", + "coverage": "lerna run coverage --", "docs:install": "pip install --user -r docs/requirements.txt", "docs:build": "lerna run check-readme && lerna run docs:build && ./scripts/prepare-docs.sh", "docs:lint": "prettier '**/*.md' --check", diff --git a/packages/api/package.json b/packages/api/package.json index a8b77bd662dd..f1ad27891fbd 100644 --- a/packages/api/package.json +++ b/packages/api/package.json @@ -60,7 +60,7 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F lodestar-api", + "coverage": "codecov -F api", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/beacon-node/package.json b/packages/beacon-node/package.json index ec17346bbc47..1f2fa210a48c 100644 --- a/packages/beacon-node/package.json +++ b/packages/beacon-node/package.json @@ -72,7 +72,7 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F lodestar", + "coverage": "codecov -F beacon-node", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", diff --git a/packages/config/package.json b/packages/config/package.json index 2e2823cd6db4..62ae1043b6c2 100644 --- a/packages/config/package.json +++ b/packages/config/package.json @@ -47,6 +47,7 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", + "coverage": "codecov -F config", "lint": "eslint --color --ext .ts src/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/db/package.json b/packages/db/package.json index 6161ef625166..ad2c6a785ffc 100644 --- a/packages/db/package.json +++ b/packages/db/package.json @@ -28,7 +28,7 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F lodestar-fork-choice", + "coverage": "codecov -F db", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/flare/package.json b/packages/flare/package.json index d7e2939c3df2..73f8c65e4dcc 100644 --- a/packages/flare/package.json +++ b/packages/flare/package.json @@ -41,6 +41,7 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\" flare --help", "check-types": "tsc", + "coverage": "codecov -F flare", "lint": "eslint --color --ext .ts src/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/fork-choice/package.json b/packages/fork-choice/package.json index 56143dc46d37..5355da604e66 100644 --- a/packages/fork-choice/package.json +++ b/packages/fork-choice/package.json @@ -29,7 +29,7 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F lodestar-fork-choice", + "coverage": "codecov -F fork-choice", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/light-client/package.json b/packages/light-client/package.json index b32d9ad6556f..c3c6a4d6e8a9 100644 --- a/packages/light-client/package.json +++ b/packages/light-client/package.json @@ -54,7 +54,7 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F lodestar-light-client", + "coverage": "codecov -F light-client", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/logger/package.json b/packages/logger/package.json index 01ec8aec2444..6adf3d927242 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -53,6 +53,7 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", + "coverage": "codecov -F logger", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", diff --git a/packages/params/package.json b/packages/params/package.json index 980363d1feb3..ea2f0132c3b0 100644 --- a/packages/params/package.json +++ b/packages/params/package.json @@ -50,6 +50,7 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", + "coverage": "codecov -F params", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/prover/package.json b/packages/prover/package.json index b88c42f4f01a..8e7e43f3ff94 100644 --- a/packages/prover/package.json +++ b/packages/prover/package.json @@ -48,7 +48,7 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F lodestar-api", + "coverage": "codecov -F prover", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", diff --git a/packages/reqresp/package.json b/packages/reqresp/package.json index 9e2919a0c6d8..00c840b930fd 100644 --- a/packages/reqresp/package.json +++ b/packages/reqresp/package.json @@ -45,7 +45,7 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F lodestar-api", + "coverage": "codecov -F reqresp", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/spec-test-util/package.json b/packages/spec-test-util/package.json index 1b2218fff1e1..f071387655c7 100644 --- a/packages/spec-test-util/package.json +++ b/packages/spec-test-util/package.json @@ -44,6 +44,7 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/downloadTests.js') })()\"", "check-types": "tsc", + "coverage": "codecov -F spec-test-util", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", diff --git a/packages/state-transition/package.json b/packages/state-transition/package.json index ad6148b51984..e14453fc2c3b 100644 --- a/packages/state-transition/package.json +++ b/packages/state-transition/package.json @@ -50,6 +50,7 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", + "coverage": "codecov -F state-transition", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/types/package.json b/packages/types/package.json index b10063cb34d5..77d2df921e1f 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -59,6 +59,7 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", + "coverage": "codecov -F types", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/utils/package.json b/packages/utils/package.json index 16f663e8f07d..6c4ebd0cca7d 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -28,6 +28,7 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc && vitest --run --typecheck --dir test/types/", + "coverage": "codecov -F utils", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test:unit": "vitest --run --dir test/unit", diff --git a/packages/validator/package.json b/packages/validator/package.json index 211627c6ace6..db81fe33100b 100644 --- a/packages/validator/package.json +++ b/packages/validator/package.json @@ -32,7 +32,7 @@ "test:spec": "vitest --run --config vitest.spec.config.ts --dir test/spec/", "test:e2e": "LODESTAR_PRESET=mainnet vitest --run --config vitest.e2e.config.ts --dir test/e2e", "download-spec-tests": "node --loader=ts-node/esm test/spec/downloadTests.ts", - "coverage": "codecov -F lodestar-validator", + "coverage": "codecov -F validator", "check-readme": "typescript-docs-verifier" }, "repository": { From 4dae089da032f5ef6490641ddff2181a3100a34c Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 10:43:47 +0100 Subject: [PATCH 02/12] Update the CI tasks to remove warning --- .github/workflows/benchmark.yml | 4 +-- .github/workflows/codeql-analysis.yml | 2 +- .github/workflows/docs-check.yml | 4 +-- .github/workflows/docs.yml | 4 +-- .github/workflows/publish-dev.yml | 6 ++-- .github/workflows/publish-rc.yml | 8 ++--- .github/workflows/publish-stable.yml | 8 ++--- .github/workflows/test-sim-merge.yml | 4 +-- .github/workflows/test-sim.yml | 4 +-- .github/workflows/test.yml | 42 +++++++++++++-------------- 10 files changed, 43 insertions(+), 43 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index b5fa586c7a8b..efb9e0231e20 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -30,8 +30,8 @@ jobs: steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: 20 check-latest: true diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 726199e68549..2d635afe2688 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -47,7 +47,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL diff --git a/.github/workflows/docs-check.yml b/.github/workflows/docs-check.yml index 4dbbcdce5f5c..9b20732c2a56 100644 --- a/.github/workflows/docs-check.yml +++ b/.github/workflows/docs-check.yml @@ -12,8 +12,8 @@ jobs: runs-on: ubuntu-latest steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: 20 cache: yarn diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index a47f236b3470..123ec596f1a2 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -25,11 +25,11 @@ jobs: echo "Deploying ref: $DEPLOY_REF" # Checkout the correct ref being deployed - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: ref: ${{ env.DEPLOY_REF }} - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: 20 check-latest: true diff --git a/.github/workflows/publish-dev.yml b/.github/workflows/publish-dev.yml index 2e71cc86c33c..e38abd9e68dc 100644 --- a/.github/workflows/publish-dev.yml +++ b/.github/workflows/publish-dev.yml @@ -15,10 +15,10 @@ jobs: runs-on: buildjet-4vcpu-ubuntu-2204 steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0 - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: 20 registry-url: "https://registry.npmjs.org" @@ -109,7 +109,7 @@ jobs: runs-on: buildjet-4vcpu-ubuntu-2204 needs: npm steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 # https://github.com/docker/setup-qemu-action - name: Set up QEMU uses: docker/setup-qemu-action@v1 diff --git a/.github/workflows/publish-rc.yml b/.github/workflows/publish-rc.yml index c0dfe3b513dd..214c3497db1a 100644 --- a/.github/workflows/publish-rc.yml +++ b/.github/workflows/publish-rc.yml @@ -15,7 +15,7 @@ jobs: runs-on: buildjet-4vcpu-ubuntu-2204 steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 @@ -49,10 +49,10 @@ jobs: if: needs.tag.outputs.is_rc == 'true' steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0 # Needs full depth for changelog generation - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: 20 check-latest: true @@ -132,7 +132,7 @@ jobs: needs: [tag, npm] if: needs.tag.outputs.is_rc == 'true' steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: scripts/await-release.sh ${{ needs.tag.outputs.tag }} rc 900 # https://github.com/docker/setup-qemu-action - name: Set up QEMU diff --git a/.github/workflows/publish-stable.yml b/.github/workflows/publish-stable.yml index c0d046891bdf..933dc0b0ca4b 100644 --- a/.github/workflows/publish-stable.yml +++ b/.github/workflows/publish-stable.yml @@ -15,7 +15,7 @@ jobs: runs-on: buildjet-4vcpu-ubuntu-2204 steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 @@ -55,10 +55,10 @@ jobs: if: needs.tag.outputs.is_stable == 'true' steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0 # Needs full depth for changelog generation - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: 20 check-latest: true @@ -132,7 +132,7 @@ jobs: needs: [tag, npm] if: needs.tag.outputs.is_stable == 'true' steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: scripts/await-release.sh ${{ needs.tag.outputs.tag }} latest 900 # https://github.com/docker/setup-qemu-action - name: Set up QEMU diff --git a/.github/workflows/test-sim-merge.yml b/.github/workflows/test-sim-merge.yml index 268df5620559..89c8869ce8cd 100644 --- a/.github/workflows/test-sim-merge.yml +++ b/.github/workflows/test-sim-merge.yml @@ -27,8 +27,8 @@ jobs: runs-on: buildjet-4vcpu-ubuntu-2204 steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: 20 check-latest: true diff --git a/.github/workflows/test-sim.yml b/.github/workflows/test-sim.yml index 20eee3d11e77..0e9c5ba527e6 100644 --- a/.github/workflows/test-sim.yml +++ b/.github/workflows/test-sim.yml @@ -33,8 +33,8 @@ jobs: runs-on: buildjet-4vcpu-ubuntu-2204 steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: 20 check-latest: true diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 05aae4b6af28..9a508124c6ad 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -26,8 +26,8 @@ jobs: node: [20] steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{matrix.node}} check-latest: true @@ -36,7 +36,7 @@ jobs: id: node run: echo "v8CppApiVersion=$(node --print "process.versions.modules")" >> $GITHUB_OUTPUT - name: Restore build - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 id: cache-build-restore with: path: | @@ -81,15 +81,15 @@ jobs: matrix: node: [20] steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} check-latest: true cache: yarn - name: Restore build cache id: cache-primes-restore - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: | node_modules @@ -119,15 +119,15 @@ jobs: matrix: node: [20] steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} check-latest: true cache: yarn - name: Restore build cache id: cache-primes-restore - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: | node_modules @@ -153,8 +153,8 @@ jobs: matrix: node: [20] steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node }} check-latest: true @@ -165,7 +165,7 @@ jobs: - name: Restore build cache id: cache-primes-restore - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: | node_modules @@ -206,15 +206,15 @@ jobs: node: [20] steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{matrix.node}} check-latest: true cache: yarn - name: Restore build cache id: cache-primes-restore - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: | node_modules @@ -253,15 +253,15 @@ jobs: node: [20] steps: # - Uses YAML anchors in the future - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{matrix.node}} check-latest: true cache: yarn - name: Restore build cache id: cache-primes-restore - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: | node_modules @@ -290,15 +290,15 @@ jobs: matrix: node: [20] steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{matrix.node}} check-latest: true cache: yarn - name: Restore build cache id: cache-primes-restore - uses: actions/cache/restore@v3 + uses: actions/cache/restore@v4 with: path: | node_modules From f7b535d5edb01253caa7f557fdaf1b1348a40aac Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 10:44:01 +0100 Subject: [PATCH 03/12] Fix coverage path --- .codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codecov.yml b/.codecov.yml index 0b28a665cceb..f9d25d52769e 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -38,5 +38,5 @@ ignore: flags: unit: paths: - - packages/**/test/unit + - ".*" carryforward: true From 104eac6fcb76a0607deeddf7d79a3ea0a72b268e Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 10:59:46 +0100 Subject: [PATCH 04/12] Remove the coverage for spec-test-util --- packages/spec-test-util/package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/spec-test-util/package.json b/packages/spec-test-util/package.json index f071387655c7..1b2218fff1e1 100644 --- a/packages/spec-test-util/package.json +++ b/packages/spec-test-util/package.json @@ -44,7 +44,6 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/downloadTests.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F spec-test-util", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", From 607b7a396bfa80309386135a22767e4b2a48e792 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 11:21:47 +0100 Subject: [PATCH 05/12] Update the ci tasks to clear warnings --- .github/actions/core-dump/action.yml | 2 +- .github/workflows/build-debug-node.yml | 2 +- .github/workflows/test-sim-merge.yml | 4 ++-- .github/workflows/test-sim.yml | 2 +- .github/workflows/test.yml | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/actions/core-dump/action.yml b/.github/actions/core-dump/action.yml index eae37c2101b8..e2e0b1224912 100644 --- a/.github/actions/core-dump/action.yml +++ b/.github/actions/core-dump/action.yml @@ -10,7 +10,7 @@ runs: shell: sh - name: Backup core dump - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: core-dump path: /cores/* diff --git a/.github/workflows/build-debug-node.yml b/.github/workflows/build-debug-node.yml index 9e7c1ac66fab..da97e10d8e97 100644 --- a/.github/workflows/build-debug-node.yml +++ b/.github/workflows/build-debug-node.yml @@ -44,7 +44,7 @@ jobs: working-directory: 'nodejs' - name: Upload build to artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: nodejs-debug-build-${{ github.event.inputs.version }} path: nodejs-debug-build-${{ github.event.inputs.version }} diff --git a/.github/workflows/test-sim-merge.yml b/.github/workflows/test-sim-merge.yml index 89c8869ce8cd..641d5ab2732e 100644 --- a/.github/workflows/test-sim-merge.yml +++ b/.github/workflows/test-sim-merge.yml @@ -92,7 +92,7 @@ jobs: - name: Upload debug log test files if: ${{ always() }} - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: debug-test-logs path: packages/beacon-node/test-logs @@ -144,7 +144,7 @@ jobs: - name: Upload debug log test files if: ${{ always() }} - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: debug-test-logs path: packages/beacon-node/test-logs diff --git a/.github/workflows/test-sim.yml b/.github/workflows/test-sim.yml index 0e9c5ba527e6..6adf60e98db1 100644 --- a/.github/workflows/test-sim.yml +++ b/.github/workflows/test-sim.yml @@ -96,7 +96,7 @@ jobs: - name: Upload debug log test files for "packages/cli" if: ${{ always() }} - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: debug-test-logs-cli path: packages/cli/test-logs diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9a508124c6ad..086f73c21495 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -238,7 +238,7 @@ jobs: - name: Upload debug log test for test env if: ${{ always() }} - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: debug-e2e-test-logs-node-${{matrix.node}} path: test-logs/e2e-test-env From c64c5d392d18434a37a0dbb227cf3e2682e9fa71 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 11:44:55 +0100 Subject: [PATCH 06/12] Use latest codecov uploader --- .github/workflows/test.yml | 7 +++- package.json | 2 +- yarn.lock | 82 +++++--------------------------------- 3 files changed, 17 insertions(+), 74 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 086f73c21495..cdf89aad8edc 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -194,8 +194,11 @@ jobs: # if: ${{ failure() && steps.unit_tests.conclusion == 'failure' }} - name: Upload coverage data - run: yarn coverage -F unit - + uses: codecov/codecov-action@v4 + with: + fail_ci_if_error: true + verbose: true # optional (default = false) + e2e-tests: name: E2E Tests runs-on: buildjet-4vcpu-ubuntu-2204 diff --git a/package.json b/package.json index c7d1a475db1c..c06a13b3c50c 100644 --- a/package.json +++ b/package.json @@ -20,6 +20,7 @@ "check-readme": "lerna run check-readme", "check-types": "lerna run check-types", "check-spelling": "pyspelling -c .pyspelling.yml -v", + "coverage:download": "codecov -F api", "coverage": "lerna run coverage --", "docs:install": "pip install --user -r docs/requirements.txt", "docs:build": "lerna run check-readme && lerna run docs:build && ./scripts/prepare-docs.sh", @@ -54,7 +55,6 @@ "@typescript-eslint/parser": "6.7.2", "@vitest/coverage-v8": "^1.2.1", "@vitest/browser": "^1.2.1", - "codecov": "^3.8.3", "crypto-browserify": "^3.12.0", "electron": "^26.2.2", "eslint": "^8.50.0", diff --git a/yarn.lock b/yarn.lock index 427db4fdc496..f84e27c73d3a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3835,11 +3835,6 @@ argparse@^2.0.1: resolved "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz" integrity sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q== -argv@0.0.2: - version "0.0.2" - resolved "https://registry.npmjs.org/argv/-/argv-0.0.2.tgz" - integrity sha1-7L0W+JSbFXGDcRsb2jNPN4QBhas= - aria-query@^5.0.0: version "5.3.0" resolved "https://registry.yarnpkg.com/aria-query/-/aria-query-5.3.0.tgz#650c569e41ad90b51b3d7df5e5eed1c7549c103e" @@ -4818,17 +4813,6 @@ cmd-shim@6.0.1: resolved "https://registry.yarnpkg.com/cmd-shim/-/cmd-shim-6.0.1.tgz#a65878080548e1dca760b3aea1e21ed05194da9d" integrity sha512-S9iI9y0nKR4hwEQsVWpyxld/6kRfGepGfzff83FcaiEBpmvlbA2nnGe7Cylgrx2f/p1P5S5wpRm9oL8z1PbS3Q== -codecov@^3.8.3: - version "3.8.3" - resolved "https://registry.npmjs.org/codecov/-/codecov-3.8.3.tgz" - integrity sha512-Y8Hw+V3HgR7V71xWH2vQ9lyS358CbGCldWlJFR0JirqoGtOoas3R3/OclRTvgUYFK29mmJICDPauVKmpqbwhOA== - dependencies: - argv "0.0.2" - ignore-walk "3.0.4" - js-yaml "3.14.1" - teeny-request "7.1.1" - urlgrey "1.0.0" - color-convert@^1.9.0, color-convert@^1.9.1: version "1.9.3" resolved "https://registry.yarnpkg.com/color-convert/-/color-convert-1.9.3.tgz#bb71850690e1f136567de629d2d5471deda4c1e8" @@ -6387,13 +6371,6 @@ fast-uri@^2.0.0, fast-uri@^2.1.0: resolved "https://registry.yarnpkg.com/fast-uri/-/fast-uri-2.2.0.tgz#519a0f849bef714aad10e9753d69d8f758f7445a" integrity sha512-cIusKBIt/R/oI6z/1nyfe2FvGKVTohVRfvkOhvx0nCEW+xf5NoCXjAHcWp93uOUBchzYcsvPlrapAdX1uW+YGg== -fast-url-parser@^1.1.3: - version "1.1.3" - resolved "https://registry.npmjs.org/fast-url-parser/-/fast-url-parser-1.1.3.tgz" - integrity sha1-9K8+qfNNiicc9YrSs3WfQx8LMY0= - dependencies: - punycode "^1.3.2" - fastify-plugin@^4.0.0: version "4.5.0" resolved "https://registry.yarnpkg.com/fastify-plugin/-/fastify-plugin-4.5.0.tgz#8b853923a0bba6ab6921bb8f35b81224e6988d91" @@ -7263,7 +7240,7 @@ http-errors@2.0.0: statuses "2.0.1" toidentifier "1.0.1" -http-proxy-agent@^4.0.0, http-proxy-agent@^4.0.1: +http-proxy-agent@^4.0.1: version "4.0.1" resolved "https://registry.yarnpkg.com/http-proxy-agent/-/http-proxy-agent-4.0.1.tgz#8a8c8ef7f5932ccf953c296ca8291b95aa74aa3a" integrity sha512-k0zdNgqWTGA6aeIRVpvfVob4fL52dTfaehylg0Y4UvSySvOq/Y+BOyPrgpUrA7HylqvU8vIZGsRuXmspskV0Tg== @@ -7381,13 +7358,6 @@ ieee754@^1.1.13, ieee754@^1.1.4, ieee754@^1.2.1: resolved "https://registry.npmjs.org/ieee754/-/ieee754-1.2.1.tgz" integrity sha512-dcyqhDvX1C46lXZcVqCpK+FtMRQVdIMN6/Df5js2zouUsqG7I6sFxitIC+7KYK29KdXOLHdu9zL4sFnoVQnqaA== -ignore-walk@3.0.4: - version "3.0.4" - resolved "https://registry.npmjs.org/ignore-walk/-/ignore-walk-3.0.4.tgz" - integrity sha512-PY6Ii8o1jMRA1z4F2hRkH/xN59ox43DavKvD3oDpfurRlOJyAHpifIwpbdv1n4jt4ov0jSpw3kQ4GhJnpBL6WQ== - dependencies: - minimatch "^3.0.4" - ignore-walk@^5.0.1: version "5.0.1" resolved "https://registry.yarnpkg.com/ignore-walk/-/ignore-walk-5.0.1.tgz#5f199e23e1288f518d90358d461387788a154776" @@ -8173,14 +8143,6 @@ js-tokens@^4.0.0: resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499" integrity sha512-RdJUflcE3cUzKiMqQgsCu06FPu9UdIJO0beYbPhHN4k6apgJtifcoCtT9bcxOpYBtpD2kCM6Sbzg4CausW/PKQ== -js-yaml@3.14.1, js-yaml@^3.10.0: - version "3.14.1" - resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.1.tgz" - integrity sha512-okMH7OXXJ7YrN9Ok3/SXrnu4iX9yOk+25nqX4imS2npuvTYDmo/QEZoqwZkYaIDk3jVvBOTOIEgEhaLOynBS9g== - dependencies: - argparse "^1.0.7" - esprima "^4.0.0" - js-yaml@4.1.0, js-yaml@^4.1.0: version "4.1.0" resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz" @@ -8188,6 +8150,14 @@ js-yaml@4.1.0, js-yaml@^4.1.0: dependencies: argparse "^2.0.1" +js-yaml@^3.10.0: + version "3.14.1" + resolved "https://registry.npmjs.org/js-yaml/-/js-yaml-3.14.1.tgz" + integrity sha512-okMH7OXXJ7YrN9Ok3/SXrnu4iX9yOk+25nqX4imS2npuvTYDmo/QEZoqwZkYaIDk3jVvBOTOIEgEhaLOynBS9g== + dependencies: + argparse "^1.0.7" + esprima "^4.0.0" + jsdom@^23.0.1: version "23.0.1" resolved "https://registry.yarnpkg.com/jsdom/-/jsdom-23.0.1.tgz#ede7ff76e89ca035b11178d200710d8982ebfee0" @@ -10686,7 +10656,7 @@ punycode@1.3.2: resolved "https://registry.yarnpkg.com/punycode/-/punycode-1.3.2.tgz#9653a036fb7c1ee42342f2325cceefea3926c48d" integrity sha512-RofWgt/7fL5wP1Y7fxE7/EmTLzQVnB0ycyibJ0OOHIlJqTNzglYFxVwETOcIoJqJmpDXJ9xImDv+Fq34F/d4Dw== -punycode@^1.2.4, punycode@^1.3.2, punycode@^1.4.1: +punycode@^1.2.4, punycode@^1.4.1: version "1.4.1" resolved "https://registry.yarnpkg.com/punycode/-/punycode-1.4.1.tgz#c0d5a63b2718800ad8e1eb0fa5269c84dd41845e" integrity sha512-jmYNElW7yvO7TV33CjSmvSiE2yco3bV2czu/OzDKdMNVZQWfxCblURLhf+47syQRBntjfLdd/H0egrzIG+oaFQ== @@ -11716,13 +11686,6 @@ stream-browserify@^3.0.0: inherits "~2.0.4" readable-stream "^3.5.0" -stream-events@^1.0.5: - version "1.0.5" - resolved "https://registry.npmjs.org/stream-events/-/stream-events-1.0.5.tgz" - integrity sha512-E1GUzBSgvct8Jsb3v2X15pjzN1tYebtbLaMg+eBOUOAxgbLoSbT2NS91ckc5lJD1KfLjId+jXJRgo0qnV5Nerg== - dependencies: - stubs "^3.0.0" - stream-http@^2.7.2: version "2.8.3" resolved "https://registry.npmjs.org/stream-http/-/stream-http-2.8.3.tgz" @@ -11906,11 +11869,6 @@ strong-log-transformer@2.1.0, strong-log-transformer@^2.1.0: minimist "^1.2.0" through "^2.3.4" -stubs@^3.0.0: - version "3.0.0" - resolved "https://registry.npmjs.org/stubs/-/stubs-3.0.0.tgz" - integrity sha1-6NK6H6nJBXAwPAMLaQD31fiavls= - sumchecker@^3.0.1: version "3.0.1" resolved "https://registry.yarnpkg.com/sumchecker/-/sumchecker-3.0.1.tgz#6377e996795abb0b6d348e9b3e1dfb24345a8e42" @@ -12061,17 +12019,6 @@ tdigest@^0.1.1: dependencies: bintrees "1.0.1" -teeny-request@7.1.1: - version "7.1.1" - resolved "https://registry.npmjs.org/teeny-request/-/teeny-request-7.1.1.tgz" - integrity sha512-iwY6rkW5DDGq8hE2YgNQlKbptYpY5Nn2xecjQiNjOXWbKzPGUfmeUBCSQbbr306d7Z7U2N0TPl+/SwYRfua1Dg== - dependencies: - http-proxy-agent "^4.0.0" - https-proxy-agent "^5.0.0" - node-fetch "^2.6.1" - stream-events "^1.0.5" - uuid "^8.0.0" - temp-dir@1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/temp-dir/-/temp-dir-1.0.0.tgz#0a7c0ea26d3a39afa7e0ebea9c1fc0bc4daa011d" @@ -12660,13 +12607,6 @@ url@^0.11.0: punycode "1.3.2" querystring "0.2.0" -urlgrey@1.0.0: - version "1.0.0" - resolved "https://registry.npmjs.org/urlgrey/-/urlgrey-1.0.0.tgz" - integrity sha512-hJfIzMPJmI9IlLkby8QrsCykQ+SXDeO2W5Q9QTW3QpqZVTx4a/K7p8/5q+/isD8vsbVaFgql/gvAoQCRQ2Cb5w== - dependencies: - fast-url-parser "^1.1.3" - userhome@1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/userhome/-/userhome-1.0.0.tgz#b6491ff12d21a5e72671df9ccc8717e1c6688c0b" @@ -12707,7 +12647,7 @@ uuid@3.3.2: resolved "https://registry.yarnpkg.com/uuid/-/uuid-3.3.2.tgz#1b4af4955eb3077c501c23872fc6513811587131" integrity sha512-yXJmeNaw3DnnKAOKJE51sL/ZaYfWJRl1pK9dr19YFCu0ObS231AB1/LbqTKRAQ5kw8A90rA6fr4riOUpTZvQZA== -uuid@8.3.2, uuid@^8.0.0, uuid@^8.3.0, uuid@^8.3.2: +uuid@8.3.2, uuid@^8.3.0, uuid@^8.3.2: version "8.3.2" resolved "https://registry.npmjs.org/uuid/-/uuid-8.3.2.tgz" integrity sha512-+NYs2QeMWy+GWFOEm9xnn6HCDp0l7QBD7ml8zLUmJ+93Q5NF0NocErnwkTkXVFNiX3/fpC6afS8Dhb/gz7R7eg== From a353e3390b3dea1aacbf780ec4e481d939048fdf Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 12:06:51 +0100 Subject: [PATCH 07/12] Add codecov token --- .github/workflows/test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cdf89aad8edc..a3366beaef62 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -196,9 +196,10 @@ jobs: - name: Upload coverage data uses: codecov/codecov-action@v4 with: + token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true verbose: true # optional (default = false) - + e2e-tests: name: E2E Tests runs-on: buildjet-4vcpu-ubuntu-2204 From 3ce20e867ef53744a2076c5af0b6957bf8bde6b5 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 12:48:48 +0100 Subject: [PATCH 08/12] Update the code coverage task --- .github/workflows/test.yml | 1 + package.json | 1 - packages/api/package.json | 1 - packages/beacon-node/package.json | 1 - packages/cli/package.json | 1 - packages/config/package.json | 1 - packages/db/package.json | 1 - packages/flare/package.json | 1 - packages/fork-choice/package.json | 1 - packages/light-client/package.json | 1 - packages/logger/package.json | 1 - packages/params/package.json | 1 - packages/prover/package.json | 1 - packages/reqresp/package.json | 1 - packages/state-transition/package.json | 1 - packages/types/package.json | 1 - packages/utils/package.json | 1 - packages/validator/package.json | 1 - 18 files changed, 1 insertion(+), 17 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a3366beaef62..61be02b589be 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -199,6 +199,7 @@ jobs: token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true verbose: true # optional (default = false) + flags: "unit" e2e-tests: name: E2E Tests diff --git a/package.json b/package.json index c06a13b3c50c..fbdfdfc135b3 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,6 @@ "check-types": "lerna run check-types", "check-spelling": "pyspelling -c .pyspelling.yml -v", "coverage:download": "codecov -F api", - "coverage": "lerna run coverage --", "docs:install": "pip install --user -r docs/requirements.txt", "docs:build": "lerna run check-readme && lerna run docs:build && ./scripts/prepare-docs.sh", "docs:lint": "prettier '**/*.md' --check", diff --git a/packages/api/package.json b/packages/api/package.json index f1ad27891fbd..8b5847c1a47e 100644 --- a/packages/api/package.json +++ b/packages/api/package.json @@ -60,7 +60,6 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F api", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/beacon-node/package.json b/packages/beacon-node/package.json index 1f2fa210a48c..8a993a4e2f0f 100644 --- a/packages/beacon-node/package.json +++ b/packages/beacon-node/package.json @@ -72,7 +72,6 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F beacon-node", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", diff --git a/packages/cli/package.json b/packages/cli/package.json index 187892b54553..cbd6dba233db 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -38,7 +38,6 @@ "test:sim:deneb": "LODESTAR_PRESET=minimal node --loader ts-node/esm test/sim/deneb.test.ts", "test:sim:backup_eth_provider": "LODESTAR_PRESET=minimal node --loader ts-node/esm test/sim/backup_eth_provider.test.ts", "test": "yarn test:unit && yarn test:e2e", - "coverage": "codecov -F lodestar", "check-readme": "typescript-docs-verifier" }, "repository": { diff --git a/packages/config/package.json b/packages/config/package.json index 62ae1043b6c2..2e2823cd6db4 100644 --- a/packages/config/package.json +++ b/packages/config/package.json @@ -47,7 +47,6 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F config", "lint": "eslint --color --ext .ts src/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/db/package.json b/packages/db/package.json index ad2c6a785ffc..930a79a4333a 100644 --- a/packages/db/package.json +++ b/packages/db/package.json @@ -28,7 +28,6 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F db", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/flare/package.json b/packages/flare/package.json index 73f8c65e4dcc..d7e2939c3df2 100644 --- a/packages/flare/package.json +++ b/packages/flare/package.json @@ -41,7 +41,6 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\" flare --help", "check-types": "tsc", - "coverage": "codecov -F flare", "lint": "eslint --color --ext .ts src/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/fork-choice/package.json b/packages/fork-choice/package.json index 5355da604e66..ca1332b3ee14 100644 --- a/packages/fork-choice/package.json +++ b/packages/fork-choice/package.json @@ -29,7 +29,6 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F fork-choice", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/light-client/package.json b/packages/light-client/package.json index c3c6a4d6e8a9..8b87d714ab35 100644 --- a/packages/light-client/package.json +++ b/packages/light-client/package.json @@ -54,7 +54,6 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F light-client", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/logger/package.json b/packages/logger/package.json index 6adf3d927242..01ec8aec2444 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -53,7 +53,6 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F logger", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", diff --git a/packages/params/package.json b/packages/params/package.json index ea2f0132c3b0..980363d1feb3 100644 --- a/packages/params/package.json +++ b/packages/params/package.json @@ -50,7 +50,6 @@ "build:watch": "yarn run build --watch", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F params", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/prover/package.json b/packages/prover/package.json index 8e7e43f3ff94..5c7d8ad8d691 100644 --- a/packages/prover/package.json +++ b/packages/prover/package.json @@ -48,7 +48,6 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F prover", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit && yarn test:e2e", diff --git a/packages/reqresp/package.json b/packages/reqresp/package.json index 00c840b930fd..80fcb8d8b4f3 100644 --- a/packages/reqresp/package.json +++ b/packages/reqresp/package.json @@ -45,7 +45,6 @@ "build:release": "yarn clean && yarn run build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F reqresp", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/state-transition/package.json b/packages/state-transition/package.json index e14453fc2c3b..ad6148b51984 100644 --- a/packages/state-transition/package.json +++ b/packages/state-transition/package.json @@ -50,7 +50,6 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F state-transition", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/types/package.json b/packages/types/package.json index 77d2df921e1f..b10063cb34d5 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -59,7 +59,6 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc", - "coverage": "codecov -F types", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test": "yarn test:unit", diff --git a/packages/utils/package.json b/packages/utils/package.json index 6c4ebd0cca7d..16f663e8f07d 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -28,7 +28,6 @@ "build:release": "yarn clean && yarn build", "check-build": "node -e \"(async function() { await import('./lib/index.js') })()\"", "check-types": "tsc && vitest --run --typecheck --dir test/types/", - "coverage": "codecov -F utils", "lint": "eslint --color --ext .ts src/ test/", "lint:fix": "yarn run lint --fix", "test:unit": "vitest --run --dir test/unit", diff --git a/packages/validator/package.json b/packages/validator/package.json index db81fe33100b..65e5d1547388 100644 --- a/packages/validator/package.json +++ b/packages/validator/package.json @@ -32,7 +32,6 @@ "test:spec": "vitest --run --config vitest.spec.config.ts --dir test/spec/", "test:e2e": "LODESTAR_PRESET=mainnet vitest --run --config vitest.e2e.config.ts --dir test/e2e", "download-spec-tests": "node --loader=ts-node/esm test/spec/downloadTests.ts", - "coverage": "codecov -F validator", "check-readme": "typescript-docs-verifier" }, "repository": { From 16544b645a8b398c833cde21cb1f66f5d3dbf599 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 14:31:01 +0100 Subject: [PATCH 09/12] Add the badge --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 52c671ae6f1d..b5b8d5ae245d 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,7 @@ [![Ethereum Consensus Spec v1.1.10](https://img.shields.io/badge/ETH%20consensus--spec-1.1.10-blue)](https://github.com/ethereum/consensus-specs/releases/tag/v1.1.10) ![ES Version](https://img.shields.io/badge/ES-2021-yellow) ![Node Version](https://img.shields.io/badge/node-20.x-green) +[![codecov](https://codecov.io/gh/ChainSafe/lodestar/graph/badge.svg?token=kHAUjtLsDG)](https://codecov.io/gh/ChainSafe/lodestar) [![gitpoap badge](https://public-api.gitpoap.io/v1/repo/ChainSafe/lodestar/badge)](https://www.gitpoap.io/gh/ChainSafe/lodestar) [Lodestar](https://lodestar.chainsafe.io) is a TypeScript implementation of the [Ethereum Consensus specification](https://github.com/ethereum/consensus-specs) developed by [ChainSafe Systems](https://chainsafe.io). From 593baa5de78956ec88783991b95825a26108e804 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 14:36:31 +0100 Subject: [PATCH 10/12] Remove a temp task --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index fbdfdfc135b3..4aa463fb6084 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,6 @@ "check-readme": "lerna run check-readme", "check-types": "lerna run check-types", "check-spelling": "pyspelling -c .pyspelling.yml -v", - "coverage:download": "codecov -F api", "docs:install": "pip install --user -r docs/requirements.txt", "docs:build": "lerna run check-readme && lerna run docs:build && ./scripts/prepare-docs.sh", "docs:lint": "prettier '**/*.md' --check", From 9d951ad13a108c441e3d52521bfa249276ee4d8a Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 16:33:49 +0100 Subject: [PATCH 11/12] Split badges to two lines --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index b5b8d5ae245d..43891ce4eb4e 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,7 @@ [![npm](https://img.shields.io/npm/v/@chainsafe/lodestar)](https://www.npmjs.com/package/@chainsafe/lodestar) [![Docker Image Version (latest by date)](https://img.shields.io/docker/v/chainsafe/lodestar?color=blue&label=Docker&sort=semver)](https://hub.docker.com/r/chainsafe/lodestar) [![Ethereum Consensus Spec v1.1.10](https://img.shields.io/badge/ETH%20consensus--spec-1.1.10-blue)](https://github.com/ethereum/consensus-specs/releases/tag/v1.1.10) +
![ES Version](https://img.shields.io/badge/ES-2021-yellow) ![Node Version](https://img.shields.io/badge/node-20.x-green) [![codecov](https://codecov.io/gh/ChainSafe/lodestar/graph/badge.svg?token=kHAUjtLsDG)](https://codecov.io/gh/ChainSafe/lodestar) From bdda8e3087c4b7767564f9c63585cc0991e824a0 Mon Sep 17 00:00:00 2001 From: Nazar Hussain Date: Thu, 8 Feb 2024 16:34:54 +0100 Subject: [PATCH 12/12] Remove the token from the badge --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 43891ce4eb4e..6f682e6e87c8 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@
![ES Version](https://img.shields.io/badge/ES-2021-yellow) ![Node Version](https://img.shields.io/badge/node-20.x-green) -[![codecov](https://codecov.io/gh/ChainSafe/lodestar/graph/badge.svg?token=kHAUjtLsDG)](https://codecov.io/gh/ChainSafe/lodestar) +[![codecov](https://codecov.io/gh/ChainSafe/lodestar/graph/badge.svg)](https://codecov.io/gh/ChainSafe/lodestar) [![gitpoap badge](https://public-api.gitpoap.io/v1/repo/ChainSafe/lodestar/badge)](https://www.gitpoap.io/gh/ChainSafe/lodestar) [Lodestar](https://lodestar.chainsafe.io) is a TypeScript implementation of the [Ethereum Consensus specification](https://github.com/ethereum/consensus-specs) developed by [ChainSafe Systems](https://chainsafe.io).