Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GossipsubMaxIHaveLength config #505

Open
mkermani144 opened this issue Sep 7, 2024 · 1 comment
Open

feat: add GossipsubMaxIHaveLength config #505

mkermani144 opened this issue Sep 7, 2024 · 1 comment

Comments

@mkermani144
Copy link
Contributor

Description

In the comments here:

* peer within a heartbeat, to protect from IHAVE floods. You should adjust this value from the
* default if your system is pushing more than 5000 messages in GossipsubHistoryGossip heartbeats;
* with the defaults this is 1666 messages/s.
*/
export const GossipsubMaxIHaveLength = 5000

It is stated that it should be configured if needed:

You should adjust this value from the default if your system is pushing more than 5000 messages in GossipsubHistoryGossip heartbeats

But it's not configurable. constants.GossipsubMaxIHaveLength is used all over the code.

Expected behaviour

I think it should either be a config, or the comment should be updated. As a side note, based on my investigations, this is not part of the spec anyways.

@wemeetagain
Copy link
Member

Happy to accept a PR for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants