Skip to content

Display clippy check comments on PRs #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
clearloop opened this issue Apr 28, 2021 · 1 comment
Closed

Display clippy check comments on PRs #62

clearloop opened this issue Apr 28, 2021 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed p4 Low Priority wontfix

Comments

@clearloop
Copy link
Contributor

clearloop commented Apr 28, 2021 •
edited
Loading

Issue summary

After moving forward to CircleCI in #49, we lost the comments of clippy-check on PRs.

This issue has low priority, I'll back here when I'm free, or if there are any rust projects in ChainSafe that have the same demand, welcome to develop this feature together~

Potential Solutions

Upload artifacts with the JSON output of clippy-check in CircleCI, fork actions-rs/clippy-check downloading the JSON output and apply to PRs.

Use Github Actions ( not recommend )

Other information and links
@clearloop clearloop added good first issue Good for newcomers help wanted Extra attention is needed needs triage Issue needs to be triaged labels Apr 28, 2021
@dutterbutter dutterbutter removed the needs triage Issue needs to be triaged label Apr 28, 2021
@dutterbutter dutterbutter added the p4 Low Priority label Aug 18, 2021
@clearloop
Copy link
Contributor Author

Reopen when needed, or any better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed p4 Low Priority wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clearloop @dutterbutter