From 22a284f837449442a1834f19f7a6e6b845f85f5d Mon Sep 17 00:00:00 2001 From: Thibaut Sardan Date: Thu, 3 Aug 2023 01:04:01 +0200 Subject: [PATCH] fix reject --- packages/ui/src/components/modals/ProposalSigning.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/ui/src/components/modals/ProposalSigning.tsx b/packages/ui/src/components/modals/ProposalSigning.tsx index d1afee64..944b5c51 100644 --- a/packages/ui/src/components/modals/ProposalSigning.tsx +++ b/packages/ui/src/components/modals/ProposalSigning.tsx @@ -55,12 +55,15 @@ const ProposalSigning = ({ proposalData.callData || addedCallData ) const mustSubmitCallData = useMemo(() => { + // the proposer can only reject, and the calldata isn't needed for this + if (isProposerSelected) return false + if (!threshold || !proposalData.info?.approvals) return true // if it's the last approval call, we must use asMulti and have the call data // either from the chain, or from users return proposalData.info?.approvals.length >= threshold - 1 - }, [proposalData, threshold]) + }, [isProposerSelected, proposalData.info?.approvals, threshold]) const onSubmitting = useCallback(() => { setIsSubmitting(false) onClose()