Check for bad impl #44
Conversation
experimental-webgl2 has never existed nor is it part of any specs
|
Thanks @greggman, I appreciate you noticing this issue and providing a fix. I wrote the WebGL 2 detection many many years ago and knew it was flaky. 😄 Just one quick ask: this project uses the same CLA as Cesium (as do all AGI GitHub repos), sorry it isn't documented better. This is also the same CLA that Google uses, or at least used when I put together all the licenses maybe 7 years ago. Could you please send in a CLA before we merge this? @emackey I assume you want to test/review this? |
| @@ -467,6 +467,13 @@ $(function() { | |||
| }); | |||
| } | |||
|
|
|||
| if (gl.getError()) { | |||
There was a problem hiding this comment.
Just a question, how sensitive is this line? Is there some chance that some version of Firefox or some other browser will trip over this and fail the test even when WebGL is working? I know that Firefox can be pretty verbose with its WebGL warnings, but I don't remember if gl.getError is triggered by those warnings or only serious errors.
This might be fine, I just had to ask.
|
safari finally shipped real WebGL2 |
See #43