Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ComponentReader should not require the component byte length #668

Open
javagl opened this issue Dec 18, 2024 · 0 comments
Open

The ComponentReader should not require the component byte length #668

javagl opened this issue Dec 18, 2024 · 0 comments

Comments

@javagl
Copy link
Contributor

javagl commented Dec 18, 2024

The ComponentReader is returned by a function that receives the componentType, and it is, in turn, a function that receives (among other things) the componentTypeByteLength. This is not necessary. It can be determined from the componentType that is passed in.

When updating this, the use of this class in CesiumJS has to be taken into account (i.e. that would be a "breaking change", despite the @private...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant