Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent snapshots in test-e2e-release due to partially loaded scenes #12281

Open
lukemckinstry opened this issue Nov 1, 2024 · 1 comment

Comments

@lukemckinstry
Copy link
Contributor

What happened?

In the release process running npm run test-e2e-release produces false positive errors because elements in the scene are at slightly different states in the loading process.

Examples:
Screenshot from 2024-11-01 13-54-22
Screenshot from 2024-11-01 13-54-52
Screenshot from 2024-11-01 14-03-58

It appears the scene has not changed but snapshots were taken at slightly different states in the loading process.

More consistent criteria for taking snapshots could also reduce false positive errors in other cases, eg. animation, particle systems

Screenshot from 2024-11-01 14-04-50
Screenshot from 2024-11-01 14-05-17

Reproduction steps

...

Sandcastle example

No response

Environment

Browser:
CesiumJS Version:
Operating System:

@ggetz
Copy link
Contributor

ggetz commented Nov 5, 2024

Thanks @lukemckinstry! Some of this may have been introduced by the change in #12226.

We'll want to ensure:

  1. The examples are each set to a consistent time. CesiumJS uses the current system time by default, which can result in different lighting and simulation conditions
  2. We properly wait for network requests to settle (such as with waitForLoadState("networkidle") or a better handler if we can find one) at the right time
  3. We advance system time such that promises can resolve and animations run in a deterministic way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants