Update CONTRIBUTING.md #1585
Merged
Update CONTRIBUTING.md #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azrogers
reviewed
Jan 16, 2025
|
Looks good! Just one minor change @j9liu |
|
Makes sense, thanks @azrogers ! Let me know if you see anything else to change. |
azrogers
reviewed
Jan 21, 2025
CONTRIBUTING.md
Outdated
| - Follow the [Coding Guide](https://github.com/CesiumGS/cesium-native/blob/main/doc/style-guide.md). | ||
| - Verify your is formatted, as described in the Coding Guide. | ||
| - Once you are done making new commits to address feedback, add a comment to the pull request such as `"this is ready"` so we know to take another look. | ||
| - Verify that your code conforms to our [Style Guide](https://github.com/CesiumGS/cesium-native/blob/main/doc/style-guide.md). |
There was a problem hiding this comment.
Sorry I missed this the first time around, but this link is now broken as the style guide has been moved to doc/topics/style-guide.md instead. But we should probably link to https://cesium.com/learn/cesium-native/ref-doc/style-guide.html now.
|
Another link change I missed the first time around 😅. Once you get that in, I can merge it! @j9liu |
|
Fixed, thanks for the catch @azrogers! |
|
Thanks @j9liu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed several broken links and some out-of-date information, so I did a pass for correctness. I also updated the "Submitting an issue" section with more specific questions. We should start pointing to the list more often 🙂