Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to override Cesium credit system because CesiumCredit is marked internal #437

Open
kring opened this issue Mar 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@kring
Copy link
Member

kring commented Mar 18, 2024

For people that want to change how Cesium for Unity renders credits, we recommend the steps here:
#333 (comment)

But this doesn't seem to work anymore because CesiumCredit is internal, so it's impossible to follow those instructions from outside the CesiumRuntime assembly. But the change from public to internal happened before we wrote those instructions, and they did seem to work when they were written, so it's not clear what's happening. We should investigate. Most likely the solution will simply be to make CesiumCredit and related types public.

As reported here:
#333 (comment)

@kring kring added the bug Something isn't working label Mar 18, 2024
@kring kring mentioned this issue Mar 18, 2024
@TobiasWehrum
Copy link

But the change from public to internal happened before we changed those instructions, and they did seem to work when they were written, so it's not clear what's happening.

Did you maybe use another way of distribution that places the files directly inside the Asset folder, e.g. unitypackage or the Asset Store? I think without an Assembly Definition it would just become part of the project then, so, internal would not have had any effect.

@kring
Copy link
Member Author

kring commented Mar 18, 2024

It's a good question, but no, I don't think so. We've always needed an assembly definition in order to arrange for Reinterop to be invoked. It's possible I had the package installed inside my project's Packages directory, rather than installed via the Unity package manager, but it should still be a separate assembly in that scenario.

@kring
Copy link
Member Author

kring commented Aug 27, 2024

This may not actually be an issue. See here:
#333 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants