-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator - Bounding Volume Spatial Coherence #25
Comments
Please add functions to Cesium as needed. |
@lilleyse Would you like me to add this functionality to the |
Yes add it to the existing traversal in |
@rms13 let's finish the most important ones here, starting with For this it may help to reference Cesium's I think the test itself will be decomposed to eight point vs OBB checks. The OBB is basically a 2x2x2 box that is rotated and scaled by the |
Let's tackle the region tests now.
While region is technically a curved surface along the earth, I think we can assume for most cases that it is close enough to a box shape. This will heavily simplify these 4 checks. To convert a region to a box, check out
Once converted to a box the previous written comparisons can be used. |
For CesiumGS/3d-tiles-tools#9
@sumitshyamsukha
Let's do this one now:
There are three bounding volume types: region, box, and sphere. They are defined here: https://github.com/AnalyticalGraphicsInc/3d-tiles/blob/master/schema/boundingVolume.schema.json
If a tile has a content bounding volume, check that it is inside it's bounding volume. To visualize what a bounding volume / content bounding volume looks like, go to the 3D Tiles Sandcastle when running the 3d-tiles branch in Cesium and check out the
BV On/Off
andContents BV On/Off
buttons.We'll need support the following checks:
I'll update with ideas for solving some of these, but to start region inside region should be pretty straightforward. Just need to check that the west/south/east/north/min/max are within the other's values.
The text was updated successfully, but these errors were encountered: