Skip to content

Commit f8801f3

Browse files
nnethercotennethercote
committed
Remove LazyTokenStream.
It's present within `Token::Interpolated` as an optimization, so that if a nonterminal is converted to a `TokenStream` multiple times, the first-computed value is saved and reused. But in practice it's not needed. `interpolated_to_tokenstream()` is a cold function: it's only called a few dozen times while compiling rustc itself, and a few hundred times across the entire `rustc-perf` suite. Furthermore, when it is called, it is almost always the first conversion, so no benefit is gained from it. So this commit removes `LazyTokenStream`, along with the now-unnecessary `Token::interpolated()`. As well as a significant simplification, the removal speeds things up slightly, mostly due to not having to `drop` the `LazyTokenStream` instances.
1 parent d26bf74 commit f8801f3

File tree

13 files changed

+58
-113
lines changed

13 files changed

+58
-113
lines changed

‎src/librustc/hir/map/def_collector.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ impl<'a> visit::Visitor<'a> for DefCollector<'a> {
339339

340340
fn visit_token(&mut self, t: Token) {
341341
if let Token::Interpolated(nt) = t {
342-
if let token::NtExpr(ref expr) = nt.0 {
342+
if let token::NtExpr(ref expr) = *nt {
343343
if let ExprKind::Mac(..) = expr.node {
344344
self.visit_macro_invoc(expr.id);
345345
}

‎src/librustc_resolve/build_reduced_graph.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1025,7 +1025,7 @@ impl<'a, 'b> Visitor<'a> for BuildReducedGraphVisitor<'a, 'b> {
10251025

10261026
fn visit_token(&mut self, t: Token) {
10271027
if let Token::Interpolated(nt) = t {
1028-
if let token::NtExpr(ref expr) = nt.0 {
1028+
if let token::NtExpr(ref expr) = *nt {
10291029
if let ast::ExprKind::Mac(..) = expr.node {
10301030
self.visit_invoc(expr.id);
10311031
}

‎src/libsyntax/attr/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ impl MetaItem {
517517
let span = span.with_hi(segments.last().unwrap().ident.span.hi());
518518
Path { span, segments }
519519
}
520-
Some(TokenTree::Token(_, Token::Interpolated(ref nt))) => match nt.0 {
520+
Some(TokenTree::Token(_, Token::Interpolated(nt))) => match *nt {
521521
token::Nonterminal::NtIdent(ident, _) => Path::from_ident(ident),
522522
token::Nonterminal::NtMeta(ref meta) => return Some(meta.clone()),
523523
token::Nonterminal::NtPath(ref path) => path.clone(),
@@ -682,7 +682,7 @@ impl LitKind {
682682
match token {
683683
Token::Ident(ident, false) if ident.name == "true" => Some(LitKind::Bool(true)),
684684
Token::Ident(ident, false) if ident.name == "false" => Some(LitKind::Bool(false)),
685-
Token::Interpolated(ref nt) => match nt.0 {
685+
Token::Interpolated(nt) => match *nt {
686686
token::NtExpr(ref v) | token::NtLiteral(ref v) => match v.node {
687687
ExprKind::Lit(ref lit) => Some(lit.node.clone()),
688688
_ => None,

‎src/libsyntax/ext/base.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ impl<F> TTMacroExpander for F
266266
impl MutVisitor for AvoidInterpolatedIdents {
267267
fn visit_tt(&mut self, tt: &mut tokenstream::TokenTree) {
268268
if let tokenstream::TokenTree::Token(_, token::Interpolated(nt)) = tt {
269-
if let token::NtIdent(ident, is_raw) = nt.0 {
269+
if let token::NtIdent(ident, is_raw) = **nt {
270270
*tt = tokenstream::TokenTree::Token(ident.span,
271271
token::Ident(ident, is_raw));
272272
}

‎src/libsyntax/ext/expand.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ use syntax_pos::{Span, DUMMY_SP, FileName};
2525
use syntax_pos::hygiene::ExpnFormat;
2626

2727
use rustc_data_structures::fx::FxHashMap;
28+
use rustc_data_structures::sync::Lrc;
2829
use std::fs;
2930
use std::io::ErrorKind;
3031
use std::{iter, mem};
@@ -586,14 +587,14 @@ impl<'a, 'b> MacroExpander<'a, 'b> {
586587
}
587588
AttrProcMacro(ref mac, ..) => {
588589
self.gate_proc_macro_attr_item(attr.span, &item);
589-
let item_tok = TokenTree::Token(DUMMY_SP, Token::interpolated(match item {
590+
let item_tok = TokenTree::Token(DUMMY_SP, Token::Interpolated(Lrc::new(match item {
590591
Annotatable::Item(item) => token::NtItem(item),
591592
Annotatable::TraitItem(item) => token::NtTraitItem(item.into_inner()),
592593
Annotatable::ImplItem(item) => token::NtImplItem(item.into_inner()),
593594
Annotatable::ForeignItem(item) => token::NtForeignItem(item.into_inner()),
594595
Annotatable::Stmt(stmt) => token::NtStmt(stmt.into_inner()),
595596
Annotatable::Expr(expr) => token::NtExpr(expr),
596-
})).into();
597+
}))).into();
597598
let input = self.extract_proc_macro_attr_input(attr.tokens, attr.span);
598599
let tok_result = mac.expand(self.cx, attr.span, input, item_tok);
599600
let res = self.parse_ast_fragment(tok_result, invoc.fragment_kind,

‎src/libsyntax/ext/tt/macro_parser.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -829,7 +829,7 @@ fn may_begin_with(name: &str, token: &Token) -> bool {
829829
},
830830
"block" => match *token {
831831
Token::OpenDelim(token::Brace) => true,
832-
Token::Interpolated(ref nt) => match nt.0 {
832+
Token::Interpolated(ref nt) => match **nt {
833833
token::NtItem(_)
834834
| token::NtPat(_)
835835
| token::NtTy(_)
@@ -843,9 +843,9 @@ fn may_begin_with(name: &str, token: &Token) -> bool {
843843
},
844844
"path" | "meta" => match *token {
845845
Token::ModSep | Token::Ident(..) => true,
846-
Token::Interpolated(ref nt) => match nt.0 {
846+
Token::Interpolated(ref nt) => match **nt {
847847
token::NtPath(_) | token::NtMeta(_) => true,
848-
_ => may_be_ident(&nt.0),
848+
_ => may_be_ident(&nt),
849849
},
850850
_ => false,
851851
},
@@ -862,12 +862,12 @@ fn may_begin_with(name: &str, token: &Token) -> bool {
862862
Token::ModSep | // path
863863
Token::Lt | // path (UFCS constant)
864864
Token::BinOp(token::Shl) => true, // path (double UFCS)
865-
Token::Interpolated(ref nt) => may_be_ident(&nt.0),
865+
Token::Interpolated(ref nt) => may_be_ident(nt),
866866
_ => false,
867867
},
868868
"lifetime" => match *token {
869869
Token::Lifetime(_) => true,
870-
Token::Interpolated(ref nt) => match nt.0 {
870+
Token::Interpolated(ref nt) => match **nt {
871871
token::NtLifetime(_) | token::NtTT(_) => true,
872872
_ => false,
873873
},

‎src/libsyntax/ext/tt/transcribe.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,8 @@ pub fn transcribe(cx: &ExtCtxt<'_>,
149149
result.push(tt.clone().into());
150150
} else {
151151
sp = sp.apply_mark(cx.current_expansion.mark);
152-
let token = TokenTree::Token(sp, Token::interpolated((**nt).clone()));
152+
let token =
153+
TokenTree::Token(sp, Token::Interpolated(Lrc::new((**nt).clone())));
153154
result.push(token.into());
154155
}
155156
} else {

‎src/libsyntax/mut_visit.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -581,9 +581,8 @@ pub fn noop_visit_token<T: MutVisitor>(t: &mut Token, vis: &mut T) {
581581
token::Ident(id, _is_raw) => vis.visit_ident(id),
582582
token::Lifetime(id) => vis.visit_ident(id),
583583
token::Interpolated(nt) => {
584-
let nt = Lrc::make_mut(nt);
585-
vis.visit_interpolated(&mut nt.0);
586-
nt.1 = token::LazyTokenStream::new();
584+
let mut nt = Lrc::make_mut(nt);
585+
vis.visit_interpolated(&mut nt);
587586
}
588587
_ => {}
589588
}

‎src/libsyntax/parse/attr.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ impl<'a> Parser<'a> {
141141
/// The delimiters or `=` are still put into the resulting token stream.
142142
crate fn parse_meta_item_unrestricted(&mut self) -> PResult<'a, (ast::Path, TokenStream)> {
143143
let meta = match self.token {
144-
token::Interpolated(ref nt) => match nt.0 {
144+
token::Interpolated(ref nt) => match **nt {
145145
Nonterminal::NtMeta(ref meta) => Some(meta.clone()),
146146
_ => None,
147147
},
@@ -227,7 +227,7 @@ impl<'a> Parser<'a> {
227227
/// meta_item_inner : (meta_item | UNSUFFIXED_LIT) (',' meta_item_inner)? ;
228228
pub fn parse_meta_item(&mut self) -> PResult<'a, ast::MetaItem> {
229229
let nt_meta = match self.token {
230-
token::Interpolated(ref nt) => match nt.0 {
230+
token::Interpolated(ref nt) => match **nt {
231231
token::NtMeta(ref e) => Some(e.clone()),
232232
_ => None,
233233
},

‎src/libsyntax/parse/parser.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ enum BlockMode {
119119
macro_rules! maybe_whole_expr {
120120
($p:expr) => {
121121
if let token::Interpolated(nt) = $p.token.clone() {
122-
match nt.0 {
122+
match *nt {
123123
token::NtExpr(ref e) | token::NtLiteral(ref e) => {
124124
$p.bump();
125125
return Ok((*e).clone());
@@ -146,7 +146,7 @@ macro_rules! maybe_whole_expr {
146146
macro_rules! maybe_whole {
147147
($p:expr, $constructor:ident, |$x:ident| $e:expr) => {
148148
if let token::Interpolated(nt) = $p.token.clone() {
149-
if let token::$constructor($x) = nt.0.clone() {
149+
if let token::$constructor($x) = (*nt).clone() {
150150
$p.bump();
151151
return Ok($e);
152152
}
@@ -1570,7 +1570,7 @@ impl<'a> Parser<'a> {
15701570
Some(body)
15711571
}
15721572
token::Interpolated(ref nt) => {
1573-
match &nt.0 {
1573+
match **nt {
15741574
token::NtBlock(..) => {
15751575
*at_end = true;
15761576
let (inner_attrs, body) = self.parse_inner_attrs_and_block()?;
@@ -1913,7 +1913,7 @@ impl<'a> Parser<'a> {
19131913

19141914
fn is_named_argument(&mut self) -> bool {
19151915
let offset = match self.token {
1916-
token::Interpolated(ref nt) => match nt.0 {
1916+
token::Interpolated(ref nt) => match **nt {
19171917
token::NtPat(..) => return self.look_ahead(1, |t| t == &token::Colon),
19181918
_ => 0,
19191919
}
@@ -2099,7 +2099,7 @@ impl<'a> Parser<'a> {
20992099
/// Matches `token_lit = LIT_INTEGER | ...`.
21002100
fn parse_lit_token(&mut self) -> PResult<'a, LitKind> {
21012101
let out = match self.token {
2102-
token::Interpolated(ref nt) => match nt.0 {
2102+
token::Interpolated(ref nt) => match **nt {
21032103
token::NtExpr(ref v) | token::NtLiteral(ref v) => match v.node {
21042104
ExprKind::Lit(ref lit) => { lit.node.clone() }
21052105
_ => { return self.unexpected_last(&self.token); }
@@ -2299,7 +2299,7 @@ impl<'a> Parser<'a> {
22992299
/// attributes.
23002300
pub fn parse_path_allowing_meta(&mut self, style: PathStyle) -> PResult<'a, ast::Path> {
23012301
let meta_ident = match self.token {
2302-
token::Interpolated(ref nt) => match nt.0 {
2302+
token::Interpolated(ref nt) => match **nt {
23032303
token::NtMeta(ref meta) => match meta.node {
23042304
ast::MetaItemKind::Word => Some(meta.ident.clone()),
23052305
_ => None,
@@ -3271,7 +3271,7 @@ impl<'a> Parser<'a> {
32713271
self.meta_var_span = Some(self.span);
32723272
// Interpolated identifier and lifetime tokens are replaced with usual identifier
32733273
// and lifetime tokens, so the former are never encountered during normal parsing.
3274-
match nt.0 {
3274+
match **nt {
32753275
token::NtIdent(ident, is_raw) => (token::Ident(ident, is_raw), ident.span),
32763276
token::NtLifetime(ident) => (token::Lifetime(ident), ident.span),
32773277
_ => return,
@@ -3403,7 +3403,7 @@ impl<'a> Parser<'a> {
34033403
// can't continue an expression after an ident
34043404
token::Ident(ident, is_raw) => token::ident_can_begin_expr(ident, is_raw),
34053405
token::Literal(..) | token::Pound => true,
3406-
token::Interpolated(ref nt) => match nt.0 {
3406+
token::Interpolated(ref nt) => match **nt {
34073407
token::NtIdent(..) | token::NtExpr(..) |
34083408
token::NtBlock(..) | token::NtPath(..) => true,
34093409
_ => false,

0 commit comments

Comments
 (0)