Skip to content

Commit 857e34c

Browse files
petrochenkovpetrochenkov
committed
ast: Unmerge structures for associated items and foreign items
1 parent d905134 commit 857e34c

File tree

15 files changed

+134
-113
lines changed

15 files changed

+134
-113
lines changed

‎src/librustc_ast/ast.rs

Lines changed: 37 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2441,10 +2441,10 @@ impl Item {
24412441
}
24422442
}
24432443

2444-
impl<K: IntoItemKind> Item<K> {
2444+
impl<K: Into<ItemKind>> Item<K> {
24452445
pub fn into_item(self) -> Item {
24462446
let Item { attrs, id, span, vis, ident, kind, tokens } = self;
2447-
Item { attrs, id, span, vis, ident, kind: kind.into_item_kind(), tokens }
2447+
Item { attrs, id, span, vis, ident, kind: kind.into(), tokens }
24482448
}
24492449
}
24502450

@@ -2624,20 +2624,11 @@ impl ItemKind {
26242624
}
26252625
}
26262626

2627-
pub trait IntoItemKind {
2628-
fn into_item_kind(self) -> ItemKind;
2629-
}
2630-
2631-
// FIXME(Centril): These definitions should be unmerged;
2632-
// see https://github.com/rust-lang/rust/pull/69194#discussion_r379899975
2633-
pub type ForeignItem = Item<AssocItemKind>;
2634-
pub type ForeignItemKind = AssocItemKind;
2635-
26362627
/// Represents associated items.
26372628
/// These include items in `impl` and `trait` definitions.
26382629
pub type AssocItem = Item<AssocItemKind>;
26392630

2640-
/// Represents non-free item kinds.
2631+
/// Represents associated item kinds.
26412632
///
26422633
/// The term "provided" in the variants below refers to the item having a default
26432634
/// definition / body. Meanwhile, a "required" item lacks a definition / body.
@@ -2646,36 +2637,59 @@ pub type AssocItem = Item<AssocItemKind>;
26462637
/// means "provided" and conversely `None` means "required".
26472638
#[derive(Clone, RustcEncodable, RustcDecodable, Debug)]
26482639
pub enum AssocItemKind {
2649-
/// A constant, `const $ident: $ty $def?;` where `def ::= "=" $expr? ;`.
2640+
/// An associated constant, `const $ident: $ty $def?;` where `def ::= "=" $expr? ;`.
26502641
/// If `def` is parsed, then the constant is provided, and otherwise required.
26512642
Const(Defaultness, P<Ty>, Option<P<Expr>>),
2652-
/// A static item (`static FOO: u8`).
2653-
Static(P<Ty>, Mutability, Option<P<Expr>>),
2654-
/// A function.
2643+
/// An associated function.
26552644
Fn(Defaultness, FnSig, Generics, Option<P<Block>>),
2656-
/// A type.
2645+
/// An associated type.
26572646
TyAlias(Defaultness, Generics, GenericBounds, Option<P<Ty>>),
2658-
/// A macro expanding to items.
2647+
/// A macro expanding to associated items.
26592648
Macro(Mac),
26602649
}
26612650

26622651
impl AssocItemKind {
26632652
pub fn defaultness(&self) -> Defaultness {
26642653
match *self {
26652654
Self::Const(def, ..) | Self::Fn(def, ..) | Self::TyAlias(def, ..) => def,
2666-
Self::Macro(..) | Self::Static(..) => Defaultness::Final,
2655+
Self::Macro(..) => Defaultness::Final,
26672656
}
26682657
}
26692658
}
26702659

2671-
impl IntoItemKind for AssocItemKind {
2672-
fn into_item_kind(self) -> ItemKind {
2673-
match self {
2660+
impl From<AssocItemKind> for ItemKind {
2661+
fn from(assoc_item_kind: AssocItemKind) -> ItemKind {
2662+
match assoc_item_kind {
26742663
AssocItemKind::Const(a, b, c) => ItemKind::Const(a, b, c),
2675-
AssocItemKind::Static(a, b, c) => ItemKind::Static(a, b, c),
26762664
AssocItemKind::Fn(a, b, c, d) => ItemKind::Fn(a, b, c, d),
26772665
AssocItemKind::TyAlias(a, b, c, d) => ItemKind::TyAlias(a, b, c, d),
26782666
AssocItemKind::Macro(a) => ItemKind::Mac(a),
26792667
}
26802668
}
26812669
}
2670+
2671+
/// An item in `extern` block.
2672+
#[derive(Clone, RustcEncodable, RustcDecodable, Debug)]
2673+
pub enum ForeignItemKind {
2674+
/// A foreign static item (`static FOO: u8`).
2675+
Static(P<Ty>, Mutability, Option<P<Expr>>),
2676+
/// A foreign function.
2677+
Fn(Defaultness, FnSig, Generics, Option<P<Block>>),
2678+
/// A foreign type.
2679+
TyAlias(Defaultness, Generics, GenericBounds, Option<P<Ty>>),
2680+
/// A macro expanding to foreign items.
2681+
Macro(Mac),
2682+
}
2683+
2684+
impl From<ForeignItemKind> for ItemKind {
2685+
fn from(foreign_item_kind: ForeignItemKind) -> ItemKind {
2686+
match foreign_item_kind {
2687+
ForeignItemKind::Static(a, b, c) => ItemKind::Static(a, b, c),
2688+
ForeignItemKind::Fn(a, b, c, d) => ItemKind::Fn(a, b, c, d),
2689+
ForeignItemKind::TyAlias(a, b, c, d) => ItemKind::TyAlias(a, b, c, d),
2690+
ForeignItemKind::Macro(a) => ItemKind::Mac(a),
2691+
}
2692+
}
2693+
}
2694+
2695+
pub type ForeignItem = Item<ForeignItemKind>;

‎src/librustc_ast/attr/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,6 +722,6 @@ macro_rules! derive_has_attrs {
722722
}
723723

724724
derive_has_attrs! {
725-
Item, Expr, Local, ast::ForeignItem, ast::StructField, ast::Arm,
725+
Item, Expr, Local, ast::AssocItem, ast::ForeignItem, ast::StructField, ast::Arm,
726726
ast::Field, ast::FieldPat, ast::Variant, ast::Param, GenericParam
727727
}

‎src/librustc_ast/mut_visit.rs

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -936,25 +936,12 @@ pub fn noop_flat_map_assoc_item<T: MutVisitor>(
936936
visitor: &mut T,
937937
) -> SmallVec<[P<AssocItem>; 1]> {
938938
let Item { id, ident, vis, attrs, kind, span, tokens: _ } = item.deref_mut();
939-
walk_nested_item(visitor, id, span, ident, vis, attrs, kind);
940-
smallvec![item]
941-
}
942-
943-
pub fn walk_nested_item(
944-
visitor: &mut impl MutVisitor,
945-
id: &mut NodeId,
946-
span: &mut Span,
947-
ident: &mut Ident,
948-
vis: &mut Visibility,
949-
attrs: &mut Vec<Attribute>,
950-
kind: &mut AssocItemKind,
951-
) {
952939
visitor.visit_id(id);
953940
visitor.visit_ident(ident);
954941
visitor.visit_vis(vis);
955942
visit_attrs(attrs, visitor);
956943
match kind {
957-
AssocItemKind::Const(_, ty, expr) | AssocItemKind::Static(ty, _, expr) => {
944+
AssocItemKind::Const(_, ty, expr) => {
958945
visitor.visit_ty(ty);
959946
visit_opt(expr, |expr| visitor.visit_expr(expr));
960947
}
@@ -971,6 +958,7 @@ pub fn walk_nested_item(
971958
AssocItemKind::Macro(mac) => visitor.visit_mac(mac),
972959
}
973960
visitor.visit_span(span);
961+
smallvec![item]
974962
}
975963

976964
pub fn noop_visit_fn_header<T: MutVisitor>(header: &mut FnHeader, vis: &mut T) {
@@ -1036,7 +1024,28 @@ pub fn noop_flat_map_foreign_item<T: MutVisitor>(
10361024
visitor: &mut T,
10371025
) -> SmallVec<[P<ForeignItem>; 1]> {
10381026
let Item { ident, attrs, id, kind, vis, span, tokens: _ } = item.deref_mut();
1039-
walk_nested_item(visitor, id, span, ident, vis, attrs, kind);
1027+
visitor.visit_id(id);
1028+
visitor.visit_ident(ident);
1029+
visitor.visit_vis(vis);
1030+
visit_attrs(attrs, visitor);
1031+
match kind {
1032+
ForeignItemKind::Static(ty, _, expr) => {
1033+
visitor.visit_ty(ty);
1034+
visit_opt(expr, |expr| visitor.visit_expr(expr));
1035+
}
1036+
ForeignItemKind::Fn(_, sig, generics, body) => {
1037+
visitor.visit_generics(generics);
1038+
visit_fn_sig(sig, visitor);
1039+
visit_opt(body, |body| visitor.visit_block(body));
1040+
}
1041+
ForeignItemKind::TyAlias(_, generics, bounds, ty) => {
1042+
visitor.visit_generics(generics);
1043+
visit_bounds(bounds, visitor);
1044+
visit_opt(ty, |ty| visitor.visit_ty(ty));
1045+
}
1046+
ForeignItemKind::Macro(mac) => visitor.visit_mac(mac),
1047+
}
1048+
visitor.visit_span(span);
10401049
smallvec![item]
10411050
}
10421051

‎src/librustc_ast/visit.rs

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -526,8 +526,29 @@ pub fn walk_pat<'a, V: Visitor<'a>>(visitor: &mut V, pattern: &'a Pat) {
526526
}
527527

528528
pub fn walk_foreign_item<'a, V: Visitor<'a>>(visitor: &mut V, item: &'a ForeignItem) {
529-
let Item { id, span, ident, vis, attrs, kind, tokens: _ } = item;
530-
walk_nested_item(visitor, *id, *span, *ident, vis, attrs, kind, FnCtxt::Foreign);
529+
let Item { id, span, ident, ref vis, ref attrs, ref kind, tokens: _ } = *item;
530+
visitor.visit_vis(vis);
531+
visitor.visit_ident(ident);
532+
walk_list!(visitor, visit_attribute, attrs);
533+
match kind {
534+
ForeignItemKind::Static(ty, _, expr) => {
535+
visitor.visit_ty(ty);
536+
walk_list!(visitor, visit_expr, expr);
537+
}
538+
ForeignItemKind::Fn(_, sig, generics, body) => {
539+
visitor.visit_generics(generics);
540+
let kind = FnKind::Fn(FnCtxt::Foreign, ident, sig, vis, body.as_deref());
541+
visitor.visit_fn(kind, span, id);
542+
}
543+
ForeignItemKind::TyAlias(_, generics, bounds, ty) => {
544+
visitor.visit_generics(generics);
545+
walk_list!(visitor, visit_param_bound, bounds);
546+
walk_list!(visitor, visit_ty, ty);
547+
}
548+
ForeignItemKind::Macro(mac) => {
549+
visitor.visit_mac(mac);
550+
}
551+
}
531552
}
532553

533554
pub fn walk_global_asm<'a, V: Visitor<'a>>(_: &mut V, _: &'a GlobalAsm) {
@@ -610,31 +631,18 @@ pub fn walk_fn<'a, V: Visitor<'a>>(visitor: &mut V, kind: FnKind<'a>, _span: Spa
610631
}
611632

612633
pub fn walk_assoc_item<'a, V: Visitor<'a>>(visitor: &mut V, item: &'a AssocItem, ctxt: AssocCtxt) {
613-
let Item { id, span, ident, vis, attrs, kind, tokens: _ } = item;
614-
walk_nested_item(visitor, *id, *span, *ident, vis, attrs, kind, FnCtxt::Assoc(ctxt));
615-
}
616-
617-
fn walk_nested_item<'a, V: Visitor<'a>>(
618-
visitor: &mut V,
619-
id: NodeId,
620-
span: Span,
621-
ident: Ident,
622-
vis: &'a Visibility,
623-
attrs: &'a [Attribute],
624-
kind: &'a AssocItemKind,
625-
ctxt: FnCtxt,
626-
) {
634+
let Item { id, span, ident, ref vis, ref attrs, ref kind, tokens: _ } = *item;
627635
visitor.visit_vis(vis);
628636
visitor.visit_ident(ident);
629637
walk_list!(visitor, visit_attribute, attrs);
630638
match kind {
631-
AssocItemKind::Const(_, ty, expr) | AssocItemKind::Static(ty, _, expr) => {
639+
AssocItemKind::Const(_, ty, expr) => {
632640
visitor.visit_ty(ty);
633641
walk_list!(visitor, visit_expr, expr);
634642
}
635643
AssocItemKind::Fn(_, sig, generics, body) => {
636644
visitor.visit_generics(generics);
637-
let kind = FnKind::Fn(ctxt, ident, sig, vis, body.as_deref());
645+
let kind = FnKind::Fn(FnCtxt::Assoc(ctxt), ident, sig, vis, body.as_deref());
638646
visitor.visit_fn(kind, span, id);
639647
}
640648
AssocItemKind::TyAlias(_, generics, bounds, ty) => {

‎src/librustc_ast_lowering/item.rs

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -675,11 +675,6 @@ impl<'hir> LoweringContext<'_, 'hir> {
675675
let ty = self.lower_ty(t, ImplTraitContext::disallowed());
676676
hir::ForeignItemKind::Static(ty, m)
677677
}
678-
ForeignItemKind::Const(_, ref t, _) => {
679-
// For recovery purposes.
680-
let ty = self.lower_ty(t, ImplTraitContext::disallowed());
681-
hir::ForeignItemKind::Static(ty, Mutability::Not)
682-
}
683678
ForeignItemKind::TyAlias(..) => hir::ForeignItemKind::Type,
684679
ForeignItemKind::Macro(_) => panic!("macro shouldn't exist here"),
685680
},
@@ -757,8 +752,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
757752
let trait_item_def_id = self.resolver.definitions().local_def_id(i.id);
758753

759754
let (generics, kind) = match i.kind {
760-
AssocItemKind::Static(ref ty, _, ref default) // Let's pretend this is a `const`.
761-
| AssocItemKind::Const(_, ref ty, ref default) => {
755+
AssocItemKind::Const(_, ref ty, ref default) => {
762756
let ty = self.lower_ty(ty, ImplTraitContext::disallowed());
763757
let body = default.as_ref().map(|x| self.lower_const_body(i.span, Some(x)));
764758
(hir::Generics::empty(), hir::TraitItemKind::Const(ty, body))
@@ -800,11 +794,10 @@ impl<'hir> LoweringContext<'_, 'hir> {
800794

801795
fn lower_trait_item_ref(&mut self, i: &AssocItem) -> hir::TraitItemRef {
802796
let (kind, has_default) = match &i.kind {
803-
AssocItemKind::Static(_, _, default) // Let's pretend this is a `const` for recovery.
804-
| AssocItemKind::Const(_, _, default) => {
805-
(hir::AssocItemKind::Const, default.is_some())
797+
AssocItemKind::Const(_, _, default) => (hir::AssocItemKind::Const, default.is_some()),
798+
AssocItemKind::TyAlias(_, _, _, default) => {
799+
(hir::AssocItemKind::Type, default.is_some())
806800
}
807-
AssocItemKind::TyAlias(_, _, _, default) => (hir::AssocItemKind::Type, default.is_some()),
808801
AssocItemKind::Fn(_, sig, _, default) => {
809802
(hir::AssocItemKind::Method { has_self: sig.decl.has_self() }, default.is_some())
810803
}
@@ -824,7 +817,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
824817
let impl_item_def_id = self.resolver.definitions().local_def_id(i.id);
825818

826819
let (generics, kind) = match &i.kind {
827-
AssocItemKind::Static(ty, _, expr) | AssocItemKind::Const(_, ty, expr) => {
820+
AssocItemKind::Const(_, ty, expr) => {
828821
let ty = self.lower_ty(ty, ImplTraitContext::disallowed());
829822
(
830823
hir::Generics::empty(),
@@ -892,8 +885,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
892885
vis: self.lower_visibility(&i.vis, Some(i.id)),
893886
defaultness: self.lower_defaultness(i.kind.defaultness(), true /* [1] */),
894887
kind: match &i.kind {
895-
AssocItemKind::Static(..) // Let's pretend this is a `const` for recovery.
896-
| AssocItemKind::Const(..) => hir::AssocItemKind::Const,
888+
AssocItemKind::Const(..) => hir::AssocItemKind::Const,
897889
AssocItemKind::TyAlias(.., ty) => {
898890
match ty.as_deref().and_then(|ty| ty.kind.opaque_top_hack()) {
899891
None => hir::AssocItemKind::Type,

‎src/librustc_ast_passes/ast_validation.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -976,7 +976,7 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
976976
ForeignItemKind::Static(_, _, body) => {
977977
self.check_foreign_kind_bodyless(fi.ident, "static", body.as_ref().map(|b| b.span));
978978
}
979-
ForeignItemKind::Const(..) | ForeignItemKind::Macro(..) => {}
979+
ForeignItemKind::Macro(..) => {}
980980
}
981981

982982
visit::walk_foreign_item(self, fi)

‎src/librustc_ast_passes/feature_gate.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
400400
ast::ForeignItemKind::TyAlias(..) => {
401401
gate_feature_post!(&self, extern_types, i.span, "extern types are experimental");
402402
}
403-
ast::ForeignItemKind::Macro(..) | ast::ForeignItemKind::Const(..) => {}
403+
ast::ForeignItemKind::Macro(..) => {}
404404
}
405405

406406
visit::walk_foreign_item(self, i)

‎src/librustc_ast_pretty/pprust.rs

Lines changed: 24 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -971,19 +971,7 @@ impl<'a> State<'a> {
971971
}
972972

973973
crate fn print_foreign_item(&mut self, item: &ast::ForeignItem) {
974-
let ast::Item { id, span, ident, attrs, kind, vis, tokens: _ } = item;
975-
self.print_nested_item_kind(*id, *span, *ident, attrs, kind, vis);
976-
}
977-
978-
fn print_nested_item_kind(
979-
&mut self,
980-
id: ast::NodeId,
981-
span: Span,
982-
ident: ast::Ident,
983-
attrs: &[Attribute],
984-
kind: &ast::AssocItemKind,
985-
vis: &ast::Visibility,
986-
) {
974+
let ast::Item { id, span, ident, ref attrs, ref kind, ref vis, tokens: _ } = *item;
987975
self.ann.pre(self, AnnNode::SubItem(id));
988976
self.hardbreak_if_not_bol();
989977
self.maybe_print_comment(span.lo());
@@ -992,9 +980,6 @@ impl<'a> State<'a> {
992980
ast::ForeignItemKind::Fn(def, sig, gen, body) => {
993981
self.print_fn_full(sig, ident, gen, vis, *def, body.as_deref(), attrs);
994982
}
995-
ast::ForeignItemKind::Const(def, ty, body) => {
996-
self.print_item_const(ident, None, ty, body.as_deref(), vis, *def);
997-
}
998983
ast::ForeignItemKind::Static(ty, mutbl, body) => {
999984
let def = ast::Defaultness::Final;
1000985
self.print_item_const(ident, Some(*mutbl), ty, body.as_deref(), vis, def);
@@ -1413,8 +1398,29 @@ impl<'a> State<'a> {
14131398
}
14141399

14151400
crate fn print_assoc_item(&mut self, item: &ast::AssocItem) {
1416-
let ast::Item { id, span, ident, attrs, kind, vis, tokens: _ } = item;
1417-
self.print_nested_item_kind(*id, *span, *ident, attrs, kind, vis);
1401+
let ast::Item { id, span, ident, ref attrs, ref kind, ref vis, tokens: _ } = *item;
1402+
self.ann.pre(self, AnnNode::SubItem(id));
1403+
self.hardbreak_if_not_bol();
1404+
self.maybe_print_comment(span.lo());
1405+
self.print_outer_attributes(attrs);
1406+
match kind {
1407+
ast::AssocItemKind::Fn(def, sig, gen, body) => {
1408+
self.print_fn_full(sig, ident, gen, vis, *def, body.as_deref(), attrs);
1409+
}
1410+
ast::AssocItemKind::Const(def, ty, body) => {
1411+
self.print_item_const(ident, None, ty, body.as_deref(), vis, *def);
1412+
}
1413+
ast::AssocItemKind::TyAlias(def, generics, bounds, ty) => {
1414+
self.print_associated_type(ident, generics, bounds, ty.as_deref(), vis, *def);
1415+
}
1416+
ast::AssocItemKind::Macro(m) => {
1417+
self.print_mac(m);
1418+
if m.args.need_semicolon() {
1419+
self.s.word(";");
1420+
}
1421+
}
1422+
}
1423+
self.ann.post(self, AnnNode::SubItem(id))
14181424
}
14191425

14201426
crate fn print_stmt(&mut self, st: &ast::Stmt) {

‎src/librustc_expand/expand.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -674,11 +674,12 @@ impl<'a, 'b> MacroExpander<'a, 'b> {
674674
let item_tok = TokenTree::token(
675675
token::Interpolated(Lrc::new(match item {
676676
Annotatable::Item(item) => token::NtItem(item),
677-
Annotatable::TraitItem(item)
678-
| Annotatable::ImplItem(item)
679-
| Annotatable::ForeignItem(item) => {
677+
Annotatable::TraitItem(item) | Annotatable::ImplItem(item) => {
680678
token::NtItem(P(item.and_then(ast::AssocItem::into_item)))
681679
}
680+
Annotatable::ForeignItem(item) => {
681+
token::NtItem(P(item.and_then(ast::ForeignItem::into_item)))
682+
}
682683
Annotatable::Stmt(stmt) => token::NtStmt(stmt.into_inner()),
683684
Annotatable::Expr(expr) => token::NtExpr(expr),
684685
Annotatable::Arm(..)

0 commit comments

Comments
 (0)