You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This describes a continuation of #1139. It continues on some of the same ideas, and addresses a certain bloatedness of the QueryModel.
Implement a SearchResults model. SearchResults more or less represents the state of the search results page. It should contain the following data:
a QueryModel
settings for sorting, pagination, and highlighting. Could be grouped into a SearchResultsSettings model?
retrieved documents based on the above
the total number of documents matching the search
a focused document, which can be undefined. This represents the document shown in the popup, if any.
It should handle the following functions:
Formulate an elasticsearch query by merging queryModel.toEsQuery() with settings for sorting, pagination, and highlight.
When the QueryModel or sort/pagination/highlighting settings are updated, the model should fetch new results. It should have access to the SearchService to do this.
Focus and unfocus a document from the results
The SearchResultsComponent basically contains:
controllers for sorting, pagination, and highlighting
a view for the documents
Note that sorting and highlighting are currently properties of the QueryModel, but they do not belong there, since they are only relevant within the results tab, so they should be moved here.
The text was updated successfully, but these errors were encountered:
#1307 would more or less close this. What's left is that the results model should be responsible for sorting and highlighting. This is currently handled by the query model, which is not appropriate. I'll make a new issue for that after merging.
This describes a continuation of #1139. It continues on some of the same ideas, and addresses a certain bloatedness of the
QueryModel
.Implement a
SearchResults
model. SearchResults more or less represents the state of the search results page. It should contain the following data:QueryModel
SearchResultsSettings
model?undefined
. This represents the document shown in the popup, if any.It should handle the following functions:
queryModel.toEsQuery()
with settings for sorting, pagination, and highlight.SearchService
to do this.The SearchResultsComponent basically contains:
Note that sorting and highlighting are currently properties of the
QueryModel
, but they do not belong there, since they are only relevant within the results tab, so they should be moved here.The text was updated successfully, but these errors were encountered: