Check if build system allows conversion of JavaScript to TypeScript files #1

rubenthoms · 2020-11-16T09:54:00Z

In order to allow type hints, we need to convert all JavaScript files to TypeScript files. As a prerequisite, the build system must be ensured to support TypeScript. There is a promising how2 here:
https://www.tutorialsteacher.com/typescript/converting-javascript-to-typescript

This has already been partly implemented in equinor#121. It appears the build system was already ready to take in .ts/.tsx files. However, this should be double-checked.

For the original issue see: equinor#77

NOTE: Components that do not need to be converted:

LayeredMap (was superseded by LeafletMap)
SubsurfaceMap (going to be removed)

anders-kiaer · 2020-11-19T13:25:37Z

FYI: equinor#77 (comment)

…2048) This PR was automatically created by Snyk using the credentials of a real user. <h3>Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.</h3> #### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - typescript/package.json - typescript/package-lock.json #### Vulnerabilities that will be fixed ##### With an upgrade: Severity | Priority Score (*) | Issue | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:------------------------- ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | **125/1000** **Why?** Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.01055, Social Trends: No, Days since published: 0, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.08, Score Version: V5 | Uncontrolled resource consumption [SNYK-JS-BRACES-6838727](https://snyk.io/vuln/SNYK-JS-BRACES-6838727) | No | No Known Exploit ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | **125/1000** **Why?** Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.01055, Social Trends: No, Days since published: 0, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.08, Score Version: V5 | Inefficient Regular Expression Complexity [SNYK-JS-MICROMATCH-6838728](https://snyk.io/vuln/SNYK-JS-MICROMATCH-6838728) | No | No Known Exploit (*) Note that the real score may have changed since the PR was raised. <details> <summary>Commit messages</summary> <details> <summary>Package name: @nx/jest</summary> The new version differs by 250 commits. <ul> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/e62f0b114b973fd82ba8be2d1559e7d8b1934392">e62f0b1</a> chore(repo): update nx to 16.9.0-rc.1 (#19302)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/2b84f10e690a30bc324ea36d27831b6658c8c9f8">2b84f10</a> bugfix(react-native): fix run-ios failed on 2nd run (#19287)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/295ec47f5d0cb8b2cce607d4231f0fe62e44d7d8">295ec47</a> fix(core): do not attempt to publish private npm packages (#19299)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/b0e48a602128a334919da3d1e5faa3668a32f893">b0e48a6</a> chore(repo): update nx to 16.9.0-rc.0 (#19296)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/d1fe398ea0fa5b1a503bfcb62ee05afe6f1ef213">d1fe398</a> docs(core): packages to api (#19281)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/94d8356e51afea08ec194e8dbaa176c30fe96512">94d8356</a> fix(vite): provide correct root directory when building a root project (#19298)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/ca85d2683eb2b4cabb53f7059655b6dae7f2d8a5">ca85d26</a> fix(core): unregister in-process ts transpilers when projectGraph is created (#19187)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/9f0e9c8881110a94caca1f9eddd97aa6bc4ed41d">9f0e9c8</a> chore(core): nx plugin submission nx-gcp-cache (#18172)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/e9eb10fa4b40ce93c913230cd64744655a1f8d69">e9eb10f</a> chore(core): nx plugin submission @ jnxplus/nx-maven (#19081)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/f2edb2930e2050baeb46c31bae1e78ba6fbdcb98">f2edb29</a> chore(core): remove deprecated plugins from approved-plugins.json file (#19082)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/c18c0b2eba1f693ce90e0b2a89cc99ac82bdc41e">c18c0b2</a> feat(misc): prepend cwd to directory in project generators when using as-provided format (#19227)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/78f7f9f9e5c886a450ed73a56671b32691ed0b77">78f7f9f</a> fix(nextjs): Add missing env to base Nx Env (#19201)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/903c4fe7c83bb670cdf047a28506b9be228c991a">903c4fe</a> fix(js): update generated .swcrc file to align with @ swc/[email protected] (#19214)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/75890f58dde67de30c1d17de6dcf59f8c02c3134">75890f5</a> chore(repo): remove dep from nx-dev-e2e -> devkit (#19288)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/d8261b435c582f5bab3c28f35ec80dc6026bc947">d8261b4</a> fix(repo): add native packages to the release group (#19289)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/91b145174379d4b10347ab55829bf8c282b3d8b6">91b1451</a> fix(core): ensure target-only argument is rewritten correctly to be forwarded (#17971)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/5545ffbaa9c6a339cfd1bc25f23748b3431e1dc6">5545ffb</a> feat(core): allow multiple targets in show projects commmand (#18506)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/57dc1053a8036332fd50af96b988e46dce5859b1">57dc105</a> chore(core): prepare Angular specific error only before throwing it (#18904)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/82fb209b40545b0b5f5cf312df0d0473ebdb674d">82fb209</a> fix(nx-plugin): pass full context into parseTargetString (#19154)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/1aef24be398028047d5bb70468b1c549bc9340c3">1aef24b</a> chore(angular): move parseTargetString to pass executor context (#19133)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/d4a6d325783a131c9b822e2d948df1d5ecd96dc4">d4a6d32</a> feat(core): run createDependencies plugins concurrently (#19176)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/90c811adc810bb407fa8c8dc222089802e5abb89">90c811a</a> Revert "chore(repo): increate npm fetch retires count and timeout (#1… (#19283)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/ed0456e798e3e60a4e3d0936d2cf04d8a5c9ec12">ed0456e</a> chore(repo): increate npm fetch retires count and timeout (#19191)</li> <li><a href="https://snyk.io/redirect/github/nrwl/nx/commit/6327fab2e0c6c0fd1873de85e094a053b4c34d8c">6327fab</a> chore(repo): dogfood nx release commands (#19237)</li> </ul> <a href="https://snyk.io/redirect/github/nrwl/nx/compare/eaebcc34f92db2200dab0bde2e2e1dde107a47bf...e62f0b114b973fd82ba8be2d1559e7d8b1934392">See the full diff</a> </details> </details> Check the changes in this PR to ensure they won't cause issues with your project. ------------ **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.* For more information: <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJiMGFjYjdlZC03Yjg0LTQwMWItOGMwNy1jMjFlNTMwYmQwN2QiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImIwYWNiN2VkLTdiODQtNDAxYi04YzA3LWMyMWU1MzBiZDA3ZCJ9fQ==" width="0" height="0"/> 🧐 [View latest project report](https://app.snyk.io/org/webviz-35M4scJeLGQyhekQQFqyte/project/a5a284ec-f173-4fdf-9ef2-62fea2db9114?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/webviz-35M4scJeLGQyhekQQFqyte/project/a5a284ec-f173-4fdf-9ef2-62fea2db9114?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # (snyk:metadata:{"prId":"b0acb7ed-7b84-401b-8c07-c21e530bd07d","prPublicId":"b0acb7ed-7b84-401b-8c07-c21e530bd07d","dependencies":[{"name":"@nx/jest","from":"16.5.0","to":"16.9.0"}],"packageManager":"npm","projectPublicId":"a5a284ec-f173-4fdf-9ef2-62fea2db9114","projectUrl":"https://app.snyk.io/org/webviz-35M4scJeLGQyhekQQFqyte/project/a5a284ec-f173-4fdf-9ef2-62fea2db9114?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-JS-BRACES-6838727","SNYK-JS-MICROMATCH-6838728"],"upgrade":["SNYK-JS-BRACES-6838727","SNYK-JS-MICROMATCH-6838728"],"isBreakingChange":false,"env":"prod","prType":"fix","templateVariants":["updated-fix-title","priorityScore"],"priorityScoreList":[125,125],"remediationStrategy":"vuln"}) --- **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Uncontrolled resource consumption](https://learn.snyk.io/lesson/redos/?loc=fix-pr) Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Christophe Winkler <[email protected]>

rubenthoms added enhancement New feature or request prioritized Issue should be treated prioritized. labels Nov 16, 2020

rubenthoms changed the title ~~Convert JavaScript to TypeScript files~~ Check if build system allows conversion of JavaScript to TypeScript files Nov 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check if build system allows conversion of JavaScript to TypeScript files #1

Check if build system allows conversion of JavaScript to TypeScript files #1

rubenthoms commented Nov 16, 2020 •

edited

Loading

anders-kiaer commented Nov 19, 2020

Check if build system allows conversion of JavaScript to TypeScript files #1

Check if build system allows conversion of JavaScript to TypeScript files #1

Comments

rubenthoms commented Nov 16, 2020 • edited Loading

anders-kiaer commented Nov 19, 2020

rubenthoms commented Nov 16, 2020 •

edited

Loading