Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from Fidme #168

Closed
TheLastProject opened this issue Mar 24, 2021 · 14 comments
Closed

Import from Fidme #168

TheLastProject opened this issue Mar 24, 2021 · 14 comments
Assignees
Labels

Comments

@TheLastProject
Copy link
Member

Fidme allows users to export their data by going to profile -> Data protection -> Extract my data. This sends a .zip file to the user's email address.

This zip file contains the following files:

user_profile.csv: User profile information (useless to Catima)
tickets.csv: Not quite sure what this is
loyalty_stamps.csv: Not quite sure what this is either
loyalty_stamp_rewards.csv: Again, not quite sure
loyalty_programs.csv: The loyalty cards the user has in a simple to parse CSV file
loyalty_points.csv: Not quite sure

So, we can support importing from this zip file by:

  1. Allowing the user to select it
  2. Unzip it
  3. Parse the loyalty_programs.csv file

@mgohin: Would you be willing to test this feature when it is ready?

@mgohin
Copy link

mgohin commented Mar 24, 2021

O.M.G that's reactivity !
Of course I'll test it 👍

@mgohin
Copy link

mgohin commented Mar 24, 2021

do you have any idea when it'll be available on the android app ?

@TheLastProject
Copy link
Member Author

I'm hoping to have a first prototype of this import available today or tomorrow, otherwise it'll be by the end of the week probably.

@mgohin
Copy link

mgohin commented Mar 24, 2021

Nice 👍
I'll wait until I have the import option and test it.

I'm ok to wipe app data and test until it's ok

@TheLastProject
Copy link
Member Author

I implemented it in b9e152e but I am a bit unsure about the notes the app allows you to add to your cards. Could you look into the ZIP file a Fidme export gives you? My test loyalty_programs.csv gave me the following:

Retailer;Program;Added At;Reference;Firstname;Lastname
Albert Heijn;Bonus Kaart;2021-03-24 16:47:47 UTC;123435363634;;

Anyway, I've attached a debug APK in the zip file below, please give it a try:
app-debug.zip

@mgohin
Copy link

mgohin commented Mar 24, 2021

Import seems to work well.

But when I open a card, I don't have the barcodes, only the card code, and the note at the bottom seems truncated

Screenshot_20210324-205539

@mgohin
Copy link

mgohin commented Mar 24, 2021

For the csv file :

Retailer;Program;Added At;Reference;Firstname;Lastname
Auchan;Carte Waaoh;2019-09-13 15:23:08 UTC;0491221702796;Stéphanie;

@TheLastProject
Copy link
Member Author

I'll fix the truncated note. Sadly the export format of Fidme doesn't seem to include any barcode information, it seems they just store the company name and have a loyalty card program database to know "Okay, company X uses Y barcodes". This could be fixed when we get #89 done, but sadly not before that. So this is as much as I can import, sadly.

I'll also look into the importing from an image file before the next release, so you could complete the info by doing Edit -> Barcode -> Edit Barcode for each card.

@mgohin
Copy link

mgohin commented Mar 24, 2021

Ok get it.

I confirm that notes are not exported (not sure it's often used).

Option to add a barcode from an image would be a good solution to me.

Without a company database I'm not sure fidme's import is convenient.

@TheLastProject
Copy link
Member Author

I'll leave it implemented because it's better than nothing and maybe it'll get someone more interested in helping with #89, but I understand it is of limited use. Thanks for helping test!

@mgohin
Copy link

mgohin commented Mar 24, 2021

My pleasure.
Maybe add a little warning to explain that for now, barcode types will not be set

@TheLastProject
Copy link
Member Author

I thought I did. Did the message not show up for you or did I phrase it unclearly?

image

@mgohin
Copy link

mgohin commented Mar 24, 2021

Crap, didn't read 😂

@TheLastProject
Copy link
Member Author

Happens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants