Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include atomised name in matching-ws responses to avoid pipelines and other services reparsing #1350

Open
djtfmartin opened this issue Sep 5, 2024 · 3 comments
Open

Include atomised name in matching-ws responses to avoid pipelines and other services reparsing #1350

djtfmartin opened this issue Sep 5, 2024 · 3 comments
Assignees
@djtfmartin
Labels
matching

Comments

@djtfmartin
Copy link
Contributor

Include atomised name to avoid pipelines and other services (such as pipelines) reparsing the name.
This will also remove some dependencies on the pipelines side + and unnecessary processing (which can be CPU heavy)
@djtfmartin djtfmartin self-assigned this Sep 5, 2024
djtfmartin added a commit that referenced this issue Sep 5, 2024
@djtfmartin
Include atomised name to avoid pipelines and other services reparsing…
dd75be9 
… the name

#1350
@CatalogueOfLife CatalogueOfLife deleted a comment Sep 5, 2024
@mdoering
Copy link
Member

mdoering commented Sep 5, 2024

include it where?

@djtfmartin
Copy link
Contributor Author

djtfmartin commented Sep 5, 2024 •
edited
Loading

Just in the matching-ws responses. This is to avoid any name parsing in pipelines.
I'll change issue title so its a bit clearer.

@djtfmartin djtfmartin changed the title Include atomised name to avoid pipelines and other services reparsing Include atomised name in matching-ws responses to avoid pipelines and other services reparsing Sep 5, 2024
djtfmartin added a commit that referenced this issue Sep 6, 2024
@djtfmartin
Include atomised name to avoid pipelines and other services reparsing…
c4b2f64 
… the name

#1350
djtfmartin added a commit that referenced this issue Sep 6, 2024
@djtfmartin
Include atomised name to avoid pipelines and other services reparsing…
1c7452b 
… the name

#1350
djtfmartin added a commit that referenced this issue Sep 6, 2024
@djtfmartin
Include atomised name to avoid pipelines and other services reparsing…
cb8553f 
… the name

#1350
djtfmartin added a commit that referenced this issue Sep 6, 2024
@djtfmartin
IUCN
07ca4a5 
#1350
djtfmartin added a commit that referenced this issue Sep 9, 2024
@djtfmartin
IUCN
39623d1 
#1350
djtfmartin added a commit that referenced this issue Nov 4, 2024
@djtfmartin
Fix for CatalogueOfLife/data#722
4271d6f 
Fixes for ITIS id matching and removal of wildcard prefix
Datasets config
Fix for parameter ordering
Removing the call to matchByUsageKey from matchByExternalKey - which was bypassing prefix matching
index metadata generation fix for docker
Include breakdown for all ranks
IUCN
#1350
Include atomised name to avoid pipelines and other services reparsing the name
#1350
djtfmartin added a commit that referenced this issue Nov 4, 2024
@djtfmartin
Fix for CatalogueOfLife/data#722
6db3805 
Fixes for ITIS id matching and removal of wildcard prefix
Datasets config
Fix for parameter ordering
Removing the call to matchByUsageKey from matchByExternalKey - which was bypassing prefix matching
index metadata generation fix for docker
Include breakdown for all ranks
IUCN
#1350
Include atomised name to avoid pipelines and other services reparsing the name
#1350
djtfmartin added a commit that referenced this issue Nov 5, 2024
@djtfmartin
Fixes for:
5d5b171 
* CatalogueOfLife/data#719
* CatalogueOfLife/data#722
Work for
* #1350
Fixes for prefix mapping and metadata loading
djtfmartin added a commit that referenced this issue Nov 5, 2024
@djtfmartin
Fixes for:
7faa749 
* CatalogueOfLife/data#719
* CatalogueOfLife/data#722
Work for
* #1350
Fixes for prefix mapping and metadata loading
djtfmartin added a commit that referenced this issue Nov 5, 2024
@djtfmartin
Fixes for:
c79d73f 
* CatalogueOfLife/data#719
* CatalogueOfLife/data#722
Work for
* #1350
Fixes for prefix mapping and metadata loading
@djtfmartin djtfmartin mentioned this issue Nov 5, 2024
Merged
@djtfmartin
Copy link
Contributor Author

this work is merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djtfmartin djtfmartin

Labels
matching
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdoering @djtfmartin