Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging out of quota errors #446

Closed
javitonino opened this issue Feb 1, 2018 · 2 comments
Closed

Avoid logging out of quota errors #446

javitonino opened this issue Feb 1, 2018 · 2 comments
Assignees

Comments

@javitonino
Copy link

It doesn't make much sense to log those, since there is nothing we can do (user error) and it generates a lot of noise.

@ethervoid
Copy link
Contributor

With the introduced changes we have the following response:

Before

{
  "rows": [
    {
      "cdb_geocode_namedplace_point": "0101000020E61000006C04E275FD2213C00D6C956071D44440"
    }
  ],
  "time": 0.201,
  "fields": {
    "cdb_geocode_namedplace_point": {
      "type": "geometry"
    }
  },
  "total_rows": 1,
  "warnings": [
    "cdb_dataservices_client._cdb_geocode_namedplace_point(3): [cartodb_staging_user_fef64064-3754-40b4-9032-6f7d6cd95edf_db] REMOTE WARNING: Error geocoding namedplace using geocode street point, falling back to internal geocoder"
  ]
}

After

{
  "rows": [
    {
      "cdb_geocode_namedplace_point": null
    }
  ],
  "time": 0.03,
  "fields": {
    "cdb_geocode_namedplace_point": {
      "type": "geometry"
    }
  },
  "total_rows": 1
}

Now we don't do fallback and we don't send the Quota exception to rollbar

@ethervoid
Copy link
Contributor

ethervoid commented Feb 2, 2018

FYI we have removed a part of the messages ( the geocoding ones ), to remove all the platform quota errors we need to keep moving forward with the migration to the refactor #449 but this fix should do the trick and remove a huge amount of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants