New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove asserts hurting performance #272

Open

CarloLucibello opened this issue Mar 19, 2023 · 0 comments

Owner

CarloLucibello commented Mar 19, 2023

Are there other asserts like the one in #259 hurting performances?

One could be

GraphNeuralNetworks.jl/src/layers/conv.jl

Line 1274 in 2912aeb

    
           @assert !(g isa GNNGraph{<:ADJMAT_T} && edge_weight !== nothing) "Providing external edge_weight is not yet supported for adjacency matrix graphs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment