Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded base url for collections in dts api #73

Open
balmas opened this issue May 8, 2018 · 3 comments
Open

hardcoded base url for collections in dts api #73

balmas opened this issue May 8, 2018 · 3 comments
Labels

Comments

@balmas
Copy link
Contributor

balmas commented May 8, 2018

the use of localhost:5000 as the base url for the DTS collections seems to be hardcoded
this is in the dts-draft-1 branch

@balmas balmas added the bug label May 8, 2018
@PonteIneptique
Copy link
Member

This is a good bug where a decision needs to be taken : do we want relative URIs or do we want to simply force people to enter app["SERVER_NAME "] ?

@balmas
Copy link
Contributor Author

balmas commented May 8, 2018

ah, well you know what my answer is going to be. A nice default (i.e relative URIs) and the ability to override with a setting.

PonteIneptique added a commit that referenced this issue May 8, 2018
- Added a decorator to make sure parameters are used for caching (See #74)
- Added a _external parameter to make URIs relative or absolute URIs (See #73)
@PonteIneptique
Copy link
Member

Untested (neither unit or dev server) version on 753a61f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants