Skip to content

Commit a5b6c8e

Browse files
committed
[Thermo] verified that all review comments are addressed
1 parent 746c253 commit a5b6c8e

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

interfaces/cython/cantera/base.pyx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,13 @@ cdef class _SolutionBase:
174174

175175
# Kinetics
176176
cdef vector[CxxThermoPhase*] v
177-
cdef _SolutionBase adj
177+
cdef _SolutionBase phase
178178

179179
if isinstance(self, Kinetics):
180180
v.push_back(self.thermo)
181-
for adj in adjacent:
181+
for phase in adjacent:
182182
# adjacent bulk phases for a surface phase
183-
v.push_back(adj.thermo)
183+
v.push_back(phase.thermo)
184184
self.kinetics = newKineticsMgr(deref(phaseNode), v)
185185
self._kinetics.reset(self.kinetics)
186186
else:
@@ -202,15 +202,15 @@ cdef class _SolutionBase:
202202
if not kinetics:
203203
kinetics = "none"
204204

205-
cdef ThermoPhase adj
205+
cdef ThermoPhase phase
206206
cdef Reaction reaction
207207
if isinstance(self, Kinetics):
208208
self.kinetics = CxxNewKinetics(stringify(kinetics))
209209
self._kinetics.reset(self.kinetics)
210210
self.kinetics.addPhase(deref(self.thermo))
211-
for adj in adjacent:
211+
for phase in adjacent:
212212
# adjacent bulk phases for a surface phase
213-
self.kinetics.addPhase(deref(adj.thermo))
213+
self.kinetics.addPhase(deref(phase.thermo))
214214
self.kinetics.init()
215215
self.kinetics.skipUndeclaredThirdBodies(True)
216216
for reaction in reactions:

interfaces/cython/cantera/thermo.pyx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,8 +291,8 @@ cdef class ThermoPhase(_SolutionBase):
291291

292292
property phase_id:
293293
"""
294-
The identifier of the object. The phase corresponds to the
295-
CTI/XML/YAML input file entry.
294+
The identifier of the object. The default value corresponds to the
295+
CTI/XML/YAML input file phase entry, and should remain unchanged.
296296
"""
297297
def __get__(self):
298298
return pystr(self.thermo.id())
@@ -303,8 +303,8 @@ cdef class ThermoPhase(_SolutionBase):
303303

304304
property ID:
305305
"""
306-
The identifier of the object. The default is taken from the
307-
CTI/XML/YAML input file.
306+
The identifier of the object. The default value corresponds to the
307+
CTI/XML/YAML input file phase entry, and should remain unchanged.
308308
309309
.. deprecated:: 2.5
310310

0 commit comments

Comments
 (0)