Fixing a bug where I forgot to parse out the hash

CanopyTax · May 15, 2017 · a670722 · a670722
1 parent 9e6e564
commit a670722
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "single-spa-canopy",
-  "version": "1.10.0",
+  "version": "1.10.1",
   "description": "Some helpers for single-spa child apps at canopy",
   "main": "lib/single-spa-canopy.js",
   "scripts": {

diff --git a/src/overlays.helpers.js b/src/overlays.helpers.js
@@ -74,8 +74,9 @@ function createOverlayWithText (opts, elementToAppendChild, classes) {
 	div.style.left = opts.overlay.left || 0
 	div.style.pointerEvents = 'none'
 	let backgroundColor
-	if (opts.overlay.color) {
-		backgroundColor = getRGBAFromHex(opts.overlay.color)
+	const hexRegex = /^#[A-Fa-f0-9]{6}$/g
+	if (opts.overlay.color && hexRegex.test(opts.overlay.color)) {
+		backgroundColor = getRGBAFromHex(opts.overlay.color.replace('#', ''))
 	} else if (opts.overlay.background) {
 		backgroundColor = opts.overlay.background
 	} else {