udpate styling of error boundary #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvnrsn
commented
Sep 28, 2020
| if (typeof opts !== "object" || typeof opts.featureName !== "string") { | ||
| throw new Error( | ||
| "canopy-react-error-boundary decorator should be called with an opts object that has a featureName string. e.g. @ErrorBoundary({featureName: 'life'})" | ||
| ); |
dvnrsn
commented
Sep 28, 2020
| @@ -1,73 +1,74 @@ | |||
| import React from 'react'; | |||
| import {CprButton} from 'canopy-styleguide!sofe'; | |||
dvnrsn
commented
Sep 29, 2020
| } | ||
|
|
||
| return function decorateComponent(Comp) { | ||
| return class CanopyReactErrorBoundary extends React.Component { | ||
| static displayName = `CanopyReactErrorBoundary(${opts.featureName})` | ||
| static getDerivedStateFromError(error) { | ||
| return { caughtError: true }; | ||
| } |
dvnrsn
commented
Sep 29, 2020
| this.setState({ | ||
| caughtError: err, | ||
| caughtErrorInfo: info, | ||
| }); |
There was a problem hiding this comment.
not sure why caughtErrorInfo was set in state 🤷 and caughtError should be in static getDerivedStateFromErr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.