Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STIG outputs "type":"objects" in properties.json. Pharo cannot interpret. #14

Open
pdebruic opened this issue Jun 29, 2012 · 7 comments

Comments

@pdebruic
Copy link

I was attempting to port Andres Valloud's MIT licensed hash analysis tool using Cypress. When I write it using STIG everything works great but in the properties file of his HashAnalysisToolDictionary the type is 'objects' The ClassBuilder>>#computeFormat:instSize:forSuper:ccIndex in Pharo does not know what to do with that. It expects one of #(#normal #bytes #words #variable #weak).

I'd guess that it could be "type":"normal" because that is what FileTree emits for Dictionary and its subclasses.

@pdebruic
Copy link
Author

Possible values for 'type' from VW are:

illegal, bytes, immediate, weak, objects, ephemeron, none

@dalehenrich
Copy link
Member

GemStone will eventually have some non-standard types.

I suppose we should use some defensive programming and have default type when we hit an unknown type .... although at some point in time, direct editing of the packages will be the preferred solution ... we're not necessarily trying to make it a completely smooth transition, but if there are obvious (non-complex) solutions, we can incorporate them into FileTree ... the fewer barriers to sharing code the better ...

@dalehenrich
Copy link
Member

I think that what I'll do is throw a warning if a type is not recognized ...the odds are that the class will have additional loading issues, but at least this will give you a chance to find out ...

@dalehenrich
Copy link
Member

see FileTree issue 56

@mkobetic
Copy link
Member

mkobetic commented Apr 8, 2013

Did we address this sufficiently with last year's specification update that says that type: must be dialect specific, i.e. carry a dialect prefix (_squeak_type, _vw_type, ...)?

@mkobetic
Copy link
Member

Latest STIG makes the change and emits the class type as _vw_type. Note also that this attribute is only emitted if the class type is not the usual fixed-size pointer type (as we agreed)

@dalehenrich
Copy link
Member

Yeah that sounds right ... I'm going to have to get busy here and update my FileTree implementation to keep pace with you:)

and just as an FYI, there might be a port of Cypress to Ruby (actually MagLev):)

Dale

----- Original Message -----
| From: "Martin Kobetic" [email protected]
| To: "CampSmalltalk/Cypress" [email protected]
| Sent: Wednesday, April 10, 2013 6:19:53 PM
| Subject: Re: [Cypress] STIG outputs "type":"objects" in properties.json. Pharo cannot interpret. (#14)
|
| Latest STIG makes the change and emits the class type as _vw_type. Note also
| that this attribute is only emitted if the class type is not the usual
| fixed-size pointer type (as we agreed)
|
| ---
| Reply to this email directly or view it on GitHub:
| #14 (comment)
|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants