Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative faster t-digest implementation #66

Open
Jackmrzhou opened this issue Apr 1, 2024 · 1 comment
Open

Alternative faster t-digest implementation #66

Jackmrzhou opened this issue Apr 1, 2024 · 1 comment

Comments

@Jackmrzhou
Copy link

Hi, thanks for the t-digest implementation for python!
I used this for my work and I found in the end, computing t-digest and merging t-digest becoming the bottleneck. So I read the original paper and implemented an another version of it(using the algorithm in the paper). Then I found the performance is better (around 50-100 times faster). I think the improvement part is that we can have some buffer and merge hundred of values into t-digest at once.
I wonder if I could have a PR to this repo and add an alternative implementation to it? So I can use that in my day to day work, thanks.

@CamDavidsonPilon
Copy link
Owner

Hi @Jackmrzhou, unfortunately this repo isn't actively updated. You can still PR, but I can't promise a good review or testing, or even if it will be merged. You could fork this repo, PR to your own fork, and pip-install that forked version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants