Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Isolate workspaces, screens, ignore minimised windows #22

Open
markolenik opened this issue Jun 6, 2020 · 6 comments

Comments

@markolenik
Copy link
Contributor

It would be great to have the options to isolate workspaces, screens, and to be able to ignore minimised windows. Do you think this is possible and straightforward to implement?

@e3rd
Copy link
Member

e3rd commented Jun 10, 2020

Hello, this definitely makes sense and I'll welcome any PR you propose. In the case you have no means to implement this, I'll try to take a look at it in few weeks.

@markolenik
Copy link
Contributor Author

Thanks for the positive response. I'm not familiar with writing extensions in Gnome but I'll try to give it a shot when I have time.

@e3rd
Copy link
Member

e3rd commented Jun 16, 2020

Yeah, that is the big pain, I have found nowhere a good reference guide to Gnome JS. Everything important is in https://github.com/CZ-NIC/run-or-raise/blob/master/extension.js

@markolenik
Copy link
Contributor Author

Great thank you!

@e3rd
Copy link
Member

e3rd commented Feb 26, 2021

Hi, as time goes on, the docs are better and the app may run smoother.

Great guides exist at https://gjs.guide/guides/ and https://gjs-docs.gnome.org/ . I've refactored the code so adding more modes are possible. If you want to implement the other features too, I'll welcome them.

  • isolate workspace (already done)
  • isolate screen
  • ignore minimised

How to do that?

  • create new static keyword in the Mode class
  • and in gschema.xml if the keyword should be togglable globally for all the shortcuts
  • put the logics into Shortcut.trigger method, by checking if the settings is on (either locally per shortcut or globally) by this.mode.get(Mode.KEYWORD)

@markolenik
Copy link
Contributor Author

The modes idea is fantastic, thanks for you work! I'm a bit short on time at the moment but hopefully in couple of months I'll be able to add the other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants