Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguishing different types of strings via type hints #40

Open
TomNicholas opened this issue Aug 20, 2024 · 0 comments
Open

Distinguishing different types of strings via type hints #40

TomNicholas opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
typing type hinting

Comments

@TomNicholas
Copy link
Member

Currently there are a lot of different things which are all type hinted as str, in particular paths (which should probably be pathlib.Path), urls (which we might want to use an external dependency for such as urllib3), and git-related things like tags and hashes.

We want to distinguish all of these via type hints, to make the intent of the code clearer. Otherwise it can get confusing what "source" refers to, for example.

@TomNicholas TomNicholas added the typing type hinting label Aug 20, 2024
@TomNicholas TomNicholas self-assigned this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing type hinting
Projects
None yet
Development

No branches or pull requests

1 participant