From b450609a5561db9ddfc23b41c742979f5c4b3a32 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Thu, 27 Jun 2013 10:35:06 +0000 Subject: [PATCH] For now, don't turn on -Wcast-align by default. There are at least some bugs it points out that probably mean the code won't work on machines that require alignment (e.g., SPARC machines), but we'll turn it on once we fix them. (clang is fussier than GCC about this.) svn path=/trunk/; revision=50187 --- CMakeLists.txt | 2 +- configure.ac | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 46826ba11e..2f023677e4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -124,7 +124,6 @@ set(WIRESHARK_C_FLAGS -Wendif-labels -Wpointer-arith -Warray-bounds - -Wcast-align -Wformat-security -Wshorten-64-to-32 -Wvla @@ -161,6 +160,7 @@ set(WIRESHARK_EXTRA_C_FLAGS -fstrict-overflow -Wstrict-overflow=4 -Wunreachable-code -Wunsafe-loop-optimizations + -Wcast-align -Wcast-qual -Wformat-security -Wredundant-decls diff --git a/configure.ac b/configure.ac index da7d663e32..707ed4c442 100644 --- a/configure.ac +++ b/configure.ac @@ -561,6 +561,11 @@ AC_ARG_ENABLE(extra-gcc-checks, # AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wmissing-prototypes) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wmissing-declarations) + # + # A bunch of "that might not work on SPARC" code blocks + # this one for now. + # + AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wcast-align) fi ],) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wall -W) # -W is now known as -Wextra @@ -570,7 +575,6 @@ AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wendif-labels) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wpointer-arith) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wno-pointer-sign, C) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Warray-bounds) -AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wcast-align) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wformat-security) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wold-style-definition, C) AC_WIRESHARK_GCC_CFLAGS_CHECK(-Wshorten-64-to-32)