-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using django.contrib.sites #369
Comments
Isn't sites required for generating absolute URLs? |
Right. It isn't in normal cases, but it is in things that happen outside an http request/response cycle (e.g. batch emails) |
Would static site generation need this? I'm not against removing |
The static site generation doesn't need django.contrib.sites out the box - it tries to generate relative links everywhere. Some of our renderers may use it (I haven't checked), but those should be easy to fix. We have at least the following bits that currently require django.contrib.sites:
|
It's annoying, and we never put more than one conference in an install.
Let's just go with
CONFERENCE_NAME
in settings, and get rid of our use of the sites framework.The text was updated successfully, but these errors were encountered: