Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop_na for lookups #46

Open
labouz opened this issue Jul 1, 2021 · 5 comments
Open

drop_na for lookups #46

labouz opened this issue Jul 1, 2021 · 5 comments
Assignees
@RaymondBalise @gabrielodom

Comments

@labouz
Copy link
Contributor

labouz commented Jul 1, 2021

all lookup_*() funcs should drop_na to avoid this (attempting to match on words that aren't potential drugs):

image
@gabrielodom
Copy link
Contributor

This is unnecessary for lookup_syn().

@gabrielodom
Copy link
Contributor

I think I have this fixed now. I'm making my changes in the branch "v3_enhance".

gabrielodom added a commit that referenced this issue Jul 13, 2021
@gabrielodom
Resolved Issue #46; updated and organized package dependencies (and r…
f164c6e 
…emoved tibble::, added tidyr:: dependency); fixed various formatting/style/workflow errors in lookup*() functions; added warning to lookup_syn() for more than one substance; added tests.
@labouz
Copy link
Contributor Author

labouz commented Jul 14, 2021 via email

@labouz
Copy link
Contributor Author

labouz commented Sep 15, 2022

@gabrielodom this branch never got merged :/

@gabrielodom
Copy link
Contributor

@labouz will it merge now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaymondBalise RaymondBalise

@gabrielodom gabrielodom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RaymondBalise @gabrielodom @labouz