Skip to content

Fix Clang-Tidy violations? #9

Closed
@mfdorst

Description

@mfdorst

I'm personally a big fan of linter tools, and since this is an LLVM extension it seems like we should be using Clang-Tidy.

I just wanted to check before I submit a pull request with a whole bunch of little code changes to fix clang-tidy issues.

Some examples of clang-tidy changes would be:

std::map<string, string>::const_iterator it = settings.find(name);

ClangTidy: Use auto when declaring iterators

auto it = settings.find(name);

while (!file.fail() && name.size() && name[0] == '#') {

ClangTidy: The 'empty' method should be used to check for emptiness instead of 'size'

while (!file.fail() && name.empty() && name[0] == '#') {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions