Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.3 Review #90

Open
K1ang opened this issue Mar 26, 2017 · 2 comments
Open

V0.3 Review #90

K1ang opened this issue Mar 26, 2017 · 2 comments

Comments

@K1ang
Copy link

K1ang commented Mar 26, 2017

User Guide

  • Interesting introduction.
  • Detailed command formats. Keep it up!
  • Good job guys. Based on the current progress you are well on your way to meet module expectations of the project. You can proceed further by thinking of how to optimize the UI further. It looks nice and polished, but is it as useful as it can be? Can it show a whole day's schedule at a time? When you add/edit/delete, does it give visual cues to confirm what happened was exactly what user intended?
  • The 'Command summary' section will be used heavily by our testers. Try to make it easy to use as possible. e.g. give examples for each command.
  • Good to see illustrations on the guide. Keep it up. You can also include illustrations for commands that are more complex.

Developer Guide

  • Architecture diagram require updates?
  • Detailed documentations of components. Keep it up!
  • Does Send reminders by pop-ups belong to NFR?
  • Suggested additions:
    • Explain how your design support undo/redo. There are multiple ways this can be done, so it will be useful to explain how you do it and why you chose to do it that way.
    • You can explain other interesting design decisions you made.
@R-o-y
Copy link

R-o-y commented Mar 26, 2017

hi dear tutor, thanks a lot for the feedback,
regarding the explanation of undo and redo implementation, I mention than in dev guide section 4.1
May I check are there other details I should have included?

@K1ang
Copy link
Author

K1ang commented Mar 27, 2017

Ah yes. You can ignore that sentence.
Keep it up! And keep building on the guides.
You can include interesting design decisions you made, such as the various design patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants